From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33592)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VFUWB-0007b1-3q
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 15:38:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VFUW5-0002fh-A2
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 15:38:03 -0400
Received: from cantor2.suse.de ([195.135.220.15]:55159 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VFUW5-0002fW-3B
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 15:37:57 -0400
Message-ID: <5220F48F.7000003@suse.de>
Date: Fri, 30 Aug 2013 21:37:51 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1377302436-25193-1-git-send-email-afaerber@suse.de>
In-Reply-To: <1377302436-25193-1-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 00/16] qom: Assert sufficient object
 instance size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>, peter.maydell@linaro.org, Wenchao Xia <xiawenc@linux.vnet.ibm.com>, anthony@codemonkey.ws, Paolo Bonzini <pbonzini@redhat.com>

Am 24.08.2013 02:00, schrieb Andreas F=C3=A4rber:
> Andreas F=C3=A4rber (16):
>   qom: Fix object_initialize_with_type() argument name in documentation
>   intel-hda: Pass size to hda_codec_bus_init()
>   ipack: Pass size to ipack_bus_new_inplace()
>   ide: Pass size to ide_bus_new()
>   pci: Pass size to pci_bus_new_inplace()
>   scsi: Pass size to scsi_bus_new()
>   usb: Pass size to usb_bus_new()
>   virtio-pci: Pass size to virtio_pci_bus_new()
>   s390-virtio-bus: Pass size to virtio_s390_bus_new()
>   virtio-ccw: Pass size to virtio_ccw_bus_new()
>   virtio-mmio: Pass size to virtio_mmio_bus_new()
>   qdev: Pass size to qbus_create_inplace()
>   qom: Pass available size to object_initialize()

Applied these to qom-next with the requested changes - dropping two more
(BusState *) casts and splitting the final patch in two.

https://github.com/afaerber/qemu-cpu/commits/qom-next

>   qom: Introduce type_get_instance_size()
>   qdev-monitor: Clean up qdev_device_add() variable naming
>   qdev-monitor: Avoid aborting on out-of-memory in qdev_device_add()

This part only piggy-backed upon the modified object_initialize() but is
otherwise unrelated and not urgent, so waiting for review on the new QOM
API from Anthony and others.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg