Re: [Qemu-devel] [PATCH V8 4/5] block: Add support for throttling burst max in QMP and the command line.

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1747 bytes --]

On 08/30/2013 08:36 AM, Benoît Canet wrote:
> The max parameter of the leaky bucket throttling algorithm can be used to
> allow the guest to do bursts.
> The max value is a pool of I/O that the guest can use without being throttled
> at all. Throttling is triggered once this pool is empty.
> 
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---

> @@ -1404,10 +1404,16 @@ Arguments:
>  - "device": device name (json-string)
>  - "bps":  total throughput limit in bytes per second(json-int)
>  - "bps_rd":  read throughput limit in bytes per second(json-int)
> -- "bps_wr":  read throughput limit in bytes per second(json-int)
> +- "bps_wr":  write throughput limit in bytes per second (json-int)

It's odd that you are fixing one pre-existing case of missing space, but
not all of them.  Should we split the cleanups into a separate patch?  I
already started some cleanups[1], but could respin my patch to cover
more, if desired.

> @@ -1417,7 +1423,13 @@ Example:
>                                                 "bps_wr": "0",
>                                                 "iops": "0",
>                                                 "iops_rd": "0",
> -                                               "iops_wr": "0" } }
> +                                               "iops_wr": "0",

Depending on whether my patch[1] goes in first, fix this to use '0'
instead of '"0"'.

[1] still waiting for it to hit
https://lists.gnu.org/archive/html/qemu-devel/2013-08/threads.html, but
message id <1377891353-10682-1-git-send-email-eblake@redhat.com> [PATCH]
qmp: fix integer usage in examples

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]