From: Peter Hurley <peter@hurleysoftware.com>
To: Gianluca Anzolin <gianluca@sottospazio.it>
Cc: Alexander Holler <holler@ahsoftware.de>,
gustavo@padovan.org, marcel@holtmann.org,
linux-bluetooth@vger.kernel.org, gregkh@linuxfoundation.org,
jslaby@suse.cz
Subject: Re: [PATCH v5 0/6] rfcomm: Implement rfcomm as a proper tty_port
Date: Fri, 30 Aug 2013 18:02:31 -0400 [thread overview]
Message-ID: <52211677.4000406@hurleysoftware.com> (raw)
In-Reply-To: <20130830174916.GA7204@sottospazio.it>
On 08/30/2013 01:49 PM, Gianluca Anzolin wrote:
> On Tue, Aug 27, 2013 at 01:50:25PM -0400, Peter Hurley wrote:
>> On 08/27/2013 09:57 AM, Alexander Holler wrote:
>>> Am 19.08.2013 22:20, schrieb Peter Hurley:
>>>> On 07/31/2013 01:50 PM, Peter Hurley wrote:
>>>
>>>>> I reviewed these changes and retested. All ok.
>>>>
>>>> Gustavo,
>>>>
>>>> This series fixes a crashing regression from 3.10+ forward.
>>>> Why is this not in linux-next yet?
>>>
>>> 3.8+ to be exact, just in case someone has to deal with older kernels.
>>
>> Thanks for the reminder.
>>
>> This series is too extensive to consider for -stable. Any ideas for
>> how to address this crash for -stable?
>>
>> Regards,
>> Peter Hurley
>>
>
> The tty refcount patch is needed but clearly not sufficient because the system
> locks up when the device is released.
>
> Unfortunately I cannot capture any oops, this is why I went and implemented the
> tty port methods in the first place, inspired by the usb serial code.
>
> I agree the patches are extensive and a solution is needed not only for 3.10
> kernels but also for 3.11.
>
> It's not clear for me how to debug the old code further. A couple of patches
> to make the debug process easier were mentioned before but I cannot find
> them. Could anybody point me at them?
I was thinking more along the lines of what we could go back and revert,
rather than re-engineering another solution.
Regards,
Peter Hurley
prev parent reply other threads:[~2013-08-30 22:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 15:08 [PATCH v5 0/6] rfcomm: Implement rfcomm as a proper tty_port Gianluca Anzolin
2013-07-29 15:08 ` [PATCH v5 1/6] rfcomm: Take proper tty_struct references Gianluca Anzolin
2013-07-29 15:08 ` [PATCH v5 2/6] rfcomm: Remove the device from the list in the destructor Gianluca Anzolin
2013-07-29 15:08 ` [PATCH v5 3/6] rfcomm: Move the tty initialization and cleanup out of open/close Gianluca Anzolin
2013-07-29 15:08 ` [PATCH v5 4/6] rfcomm: Implement .activate, .shutdown and .carrier_raised methods Gianluca Anzolin
2013-07-29 15:08 ` [PATCH v5 5/6] rfcomm: Fix the reference counting of tty_port Gianluca Anzolin
2013-07-29 15:08 ` [PATCH v5 6/6] rfcomm: Purge the dlc->tx_queue to avoid circular dependency Gianluca Anzolin
2013-08-20 9:21 ` Gustavo Padovan
2013-08-21 8:41 ` Gianluca Anzolin
2013-07-31 17:50 ` [PATCH v5 0/6] rfcomm: Implement rfcomm as a proper tty_port Peter Hurley
2013-08-19 20:20 ` Peter Hurley
2013-08-27 13:57 ` Alexander Holler
2013-08-27 17:50 ` Peter Hurley
2013-08-28 11:24 ` Alexander Holler
2013-08-30 17:49 ` Gianluca Anzolin
2013-08-30 21:26 ` Alexander Holler
2013-08-30 22:02 ` Peter Hurley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52211677.4000406@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=gianluca@sottospazio.it \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@padovan.org \
--cc=holler@ahsoftware.de \
--cc=jslaby@suse.cz \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.