From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54811)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1VFYpx-0000BV-Do
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 20:14:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1VFYps-0006te-DN
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 20:14:45 -0400
Message-ID: <5221356C.7000207@redhat.com>
Date: Fri, 30 Aug 2013 20:14:36 -0400
From: Cole Robinson <crobinso@redhat.com>
MIME-Version: 1.0
References: <1376344938-21374-1-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1376344938-21374-1-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH for-1.6] isapc: disable
	kvmvapic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org

On 08/12/2013 06:02 PM, Paolo Bonzini wrote:
> vapic requires the VAPIC ROM to be mapped into RAM.  This is not
> possible without PAM hardware.  This fixes a segmentation fault
> running with -M isapc.
> 
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> 
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index a19e172..3aa244a 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -743,6 +743,11 @@ static QEMUMachine isapc_machine = {
>      .init = pc_init_isa,
>      .max_cpus = 1,
>      .compat_props = (GlobalProperty[]) {
> +        {
> +            .driver   = "apic-common",
> +            .property = "kvmvapic",
> +            .value    = "off",
> +        },
>          { /* end of list */ }
>      },
>      DEFAULT_MACHINE_OPTIONS,
> 

There's a Fedora bug about a related invocation crashing:

./x86_64-softmmu/qemu-system-x86_64 -machine accel=kvm -m 128 -vga std -boot d
-cpu pentium -machine isapc

https://bugzilla.redhat.com/show_bug.cgi?id=986790

So I tried your patch on git master, but it gives:

qemu-system-x86_64: Property '.kvmvapic' not found

Changing the property name to 'vapic' fixes both issues for me.

Thanks,
Cole