From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'David S. Miller'" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH 01/31] net: ax88796: use dev_get_platdata()
Date: Sat, 31 Aug 2013 22:14:57 +0400 [thread overview]
Message-ID: <522232A1.1050105@cogentembedded.com> (raw)
In-Reply-To: <003101cea53b$9fc95b30$df5c1190$%han@samsung.com>
Hello.
On 08/30/2013 08:44 AM, Jingoo Han wrote:
> Use the wrapper function for retrieving the platform data instead of
> accessing dev->platform_data directly. This is a cosmetic change
> to make the code simpler and enhance the readability.
This hardly achieves either...
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/net/ethernet/8390/ax88796.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/net/ethernet/8390/ax88796.c b/drivers/net/ethernet/8390/ax88796.c
> index b7232a9..f92f001 100644
> --- a/drivers/net/ethernet/8390/ax88796.c
> +++ b/drivers/net/ethernet/8390/ax88796.c
> @@ -840,7 +840,7 @@ static int ax_probe(struct platform_device *pdev)
> ei_local = netdev_priv(dev);
> ax = to_ax_dev(dev);
>
> - ax->plat = pdev->dev.platform_data;
> + ax->plat = dev_get_platdata(&pdev->dev);
> platform_set_drvdata(pdev, dev);
>
> ei_local->rxcr_base = ax->plat->rcr_val;
WBR, Sergei
prev parent reply other threads:[~2013-08-31 18:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 4:44 [PATCH 01/31] net: ax88796: use dev_get_platdata() Jingoo Han
2013-08-30 4:50 ` [PATCH 02/31] net: bfin_mac: " Jingoo Han
2013-08-30 4:51 ` [PATCH 03/31] net: au1000_eth: " Jingoo Han
2013-08-30 4:52 ` [PATCH 04/31] net: bcm63xx_enet: " Jingoo Han
2013-08-30 4:54 ` [PATCH 07/31] net: ep93xx_eth: " Jingoo Han
2013-08-30 4:55 ` [PATCH 08/31] net: dm9000: " Jingoo Han
2013-08-30 4:55 ` [PATCH 09/31] net: ethoc: " Jingoo Han
2013-08-30 4:56 ` [PATCH 10/31] net: fec: " Jingoo Han
2013-08-30 5:23 ` Duan Fugang-B38611
2013-08-30 4:57 ` [PATCH 11/31] net: mv643xx_eth: " Jingoo Han
2013-08-30 4:58 ` [PATCH 12/31] net: pxa168_eth: " Jingoo Han
2013-08-30 4:58 ` [PATCH 13/31] net: ks8842: " Jingoo Han
2013-08-30 4:59 ` [PATCH 14/31] net: ks8851-ml: " Jingoo Han
2013-08-30 4:59 ` [PATCH 15/31] net: netx-eth: " Jingoo Han
2013-08-31 18:17 ` Sergei Shtylyov
2013-08-30 5:00 ` [PATCH 16/31] net: sh_eth: " Jingoo Han
2013-08-30 5:00 ` [PATCH 17/31] net: seeq: " Jingoo Han
2013-08-30 5:01 ` [PATCH 18/31] net: smc91x: " Jingoo Han
2013-08-30 5:02 ` [PATCH 19/31] net: smc911x: " Jingoo Han
2013-08-30 5:02 ` [PATCH 20/31] net: smsc911x: " Jingoo Han
2013-08-30 5:04 ` [PATCH 22/31] net: niu: " Jingoo Han
2013-08-30 5:05 ` [PATCH 23/31] net: cpmac: " Jingoo Han
2013-08-30 5:05 ` [PATCH 24/31] net: davinci_emac: " Jingoo Han
2013-08-30 5:17 ` Mugunthan V N
2013-08-30 5:06 ` [PATCH 25/31] net: davinci_mdio: " Jingoo Han
2013-08-30 5:18 ` Mugunthan V N
2013-08-30 5:06 ` [PATCH 26/31] net: tsi108: " Jingoo Han
2013-08-30 5:07 ` [PATCH 27/31] net: w5300: " Jingoo Han
2013-08-30 5:07 ` [PATCH 28/31] net: w5100: " Jingoo Han
2013-08-30 5:08 ` [PATCH 29/31] net: ixp4xx_eth: " Jingoo Han
2013-08-30 5:08 ` [PATCH 30/31] net: mdio-gpio: " Jingoo Han
2013-08-30 5:09 ` [PATCH 31/31] net: mdio-mux-gpio: " Jingoo Han
2013-08-30 5:11 ` [PATCH 05/31] net: at91_ether: " Jingoo Han
2013-08-30 7:53 ` Nicolas Ferre
2013-08-30 5:12 ` [PATCH 06/31] net: macb: " Jingoo Han
2013-08-30 7:54 ` Nicolas Ferre
2013-08-30 5:13 ` [PATCH 21/31] net: stmmac: " Jingoo Han
2013-08-30 21:45 ` [PATCH 01/31] net: ax88796: " David Miller
2013-08-31 18:14 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522232A1.1050105@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=jg1.han@samsung.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.