From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFqYB-0000NJ-Gt for qemu-devel@nongnu.org; Sat, 31 Aug 2013 15:09:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFqY6-0003mc-OW for qemu-devel@nongnu.org; Sat, 31 Aug 2013 15:09:35 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54036 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFqY6-0003m0-IR for qemu-devel@nongnu.org; Sat, 31 Aug 2013 15:09:30 -0400 Message-ID: <52223F60.4000704@suse.de> Date: Sat, 31 Aug 2013 21:09:20 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1377969760-17489-1-git-send-email-antonynpavlov@gmail.com> <1377969760-17489-3-git-send-email-antonynpavlov@gmail.com> In-Reply-To: <1377969760-17489-3-git-send-email-antonynpavlov@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 2/2] milkymist-uart: use Device::realize instead of SysBusDevice::init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Antony Pavlov Cc: Peter Crosthwaite , Michael Walle , qemu-devel@nongnu.org Am 31.08.2013 19:22, schrieb Antony Pavlov: > Use of SysBusDevice::init is deprecated. > Use Device::realize instead of SysBusDevice::init. > Check dma/pl330.c for an example of the pattern. >=20 > Also introduce TypeInfo::instance_init milkymist_uart_init() > as char/pl011.c does. >=20 > Reported-by: Peter Crosthwaite > Signed-off-by: Antony Pavlov > CC: Peter Crosthwaite > CC: Michael Walle > CC: Andreas F=C3=A4rber > --- > hw/char/milkymist-uart.c | 24 ++++++++++++++---------- > 1 file changed, 14 insertions(+), 10 deletions(-) Thanks, applied to qom-next (with shortened commit message): https://github.com/afaerber/qemu-cpu/commits/qom-next Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg