Re: [Qemu-devel] [PATCH] qapi-types.py: Fix enum struct sizes on i686

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]

On 08/31/2013 04:36 PM, Cole Robinson wrote:
> Unlike other list types, enum wasn't adding any padding, which caused
> a mismatch between the generated struct size and GenericList struct
> size. More details in a678e26cbe89f7a27cbce794c2c2784571ee9d21
> 
> This crashed qemu if calling qmp query-tpm-types for example, which
> upsets libvirt capabilities probing. Reproducer on i686:
> 
> (sleep 5; printf '{"execute":"qmp_capabilities"}\n{"execute":"query-tpm-types"}\n') | ./i386-softmmu/qemu-system-i386 -S -nodefaults -nographic -M none -qmp stdio
> 
> https://bugs.launchpad.net/qemu/+bug/1219207
> 
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  scripts/qapi-types.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

> -    %(name)s value;
> +    union {
> +        %(name)s value;
> +        uint64_t padding;
> +    };

Am I right that anonymous unions are only a C11 feature (not C99)?  But
you are just copying and pasting from the other uses in this file, so
it's not a problem.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]