From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VG9Fc-0006Pb-TY for mharc-qemu-trivial@gnu.org; Sun, 01 Sep 2013 11:07:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VG9FW-0006HF-7E for qemu-trivial@nongnu.org; Sun, 01 Sep 2013 11:07:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VG9FQ-0002LR-91 for qemu-trivial@nongnu.org; Sun, 01 Sep 2013 11:07:34 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:38506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VG9FD-0002Jw-NU; Sun, 01 Sep 2013 11:07:15 -0400 Received: from gandalf.local (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id 06570400BA; Sun, 1 Sep 2013 19:07:15 +0400 (MSK) Message-ID: <52235822.3040203@msgid.tls.msk.ru> Date: Sun, 01 Sep 2013 19:07:14 +0400 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130827 Icedove/17.0.8 MIME-Version: 1.0 To: Peter Maydell References: <1375730200-22203-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1375730200-22203-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org Subject: Re: [Qemu-trivial] [PATCH] configure: disable clang -Wstring-plus-int warning X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Sep 2013 15:07:40 -0000 05.08.2013 23:16, Peter Maydell wrote: > Some versions of clang will warn about adding integers to strings: > > disas/i386.c:4753:23: error: adding 'char' to a string does not append > to the string [-Werror,-Wstring-plus-int] > oappend ("%es:" + intel_syntax); > ~~~~~~~^~~~~~~~~~~~~~ > disas/i386.c:4753:23: note: use array indexing to silence this warning > oappend ("%es:" + intel_syntax); > ^ > & [ ] > > disas/i386.c uses this idiom to to skip a "%" prefix if using intel > rather than AT&T syntax. This seems like a reasonable thing to do, > and I don't think anybody contributing to QEMU is likely to believe > that '+' is a string concatenation operator in C, so just disable > -Wstring-plus-int. Thanks, applied to the trivial-patches queue. /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VG9FJ-0006A7-Tv for qemu-devel@nongnu.org; Sun, 01 Sep 2013 11:07:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VG9FD-0002K4-VG for qemu-devel@nongnu.org; Sun, 01 Sep 2013 11:07:21 -0400 Message-ID: <52235822.3040203@msgid.tls.msk.ru> Date: Sun, 01 Sep 2013 19:07:14 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1375730200-22203-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1375730200-22203-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: disable clang -Wstring-plus-int warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org 05.08.2013 23:16, Peter Maydell wrote: > Some versions of clang will warn about adding integers to strings: > > disas/i386.c:4753:23: error: adding 'char' to a string does not append > to the string [-Werror,-Wstring-plus-int] > oappend ("%es:" + intel_syntax); > ~~~~~~~^~~~~~~~~~~~~~ > disas/i386.c:4753:23: note: use array indexing to silence this warning > oappend ("%es:" + intel_syntax); > ^ > & [ ] > > disas/i386.c uses this idiom to to skip a "%" prefix if using intel > rather than AT&T syntax. This seems like a reasonable thing to do, > and I don't think anybody contributing to QEMU is likely to believe > that '+' is a string concatenation operator in C, so just disable > -Wstring-plus-int. Thanks, applied to the trivial-patches queue. /mjt