From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VG9I5-0007hx-Hr for mharc-qemu-trivial@gnu.org; Sun, 01 Sep 2013 11:10:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VG9Hy-0007Yb-Ps for qemu-trivial@nongnu.org; Sun, 01 Sep 2013 11:10:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VG9Hs-0003BY-Rr for qemu-trivial@nongnu.org; Sun, 01 Sep 2013 11:10:06 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:47850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VG9Hg-00039w-LE; Sun, 01 Sep 2013 11:09:48 -0400 Received: from gandalf.local (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id D2EDD400BA; Sun, 1 Sep 2013 19:09:47 +0400 (MSK) Message-ID: <522358BB.7030206@msgid.tls.msk.ru> Date: Sun, 01 Sep 2013 19:09:47 +0400 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130827 Icedove/17.0.8 MIME-Version: 1.0 To: Peter Maydell References: <1377275808-9017-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1377275808-9017-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, Jan Kiszka , qemu-devel@nongnu.org, patches@linaro.org Subject: Re: [Qemu-trivial] [PATCH] slirp/arp_table.c: Avoid shifting into sign bit of signed integers X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Sep 2013 15:10:12 -0000 23.08.2013 20:36, Peter Maydell wrote: > "0xf << 28" shifts right into the sign bit, since 0xf is a signed > integer. Use the 'U' suffix to force an unsigned shift to avoid > this undefined behaviour and a clang sanitizer warning. Thanks, applied to the trivial-patches queue. /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VG9Hm-0007Q1-Re for qemu-devel@nongnu.org; Sun, 01 Sep 2013 11:10:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VG9Hg-0003A3-Sw for qemu-devel@nongnu.org; Sun, 01 Sep 2013 11:09:54 -0400 Message-ID: <522358BB.7030206@msgid.tls.msk.ru> Date: Sun, 01 Sep 2013 19:09:47 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1377275808-9017-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1377275808-9017-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp/arp_table.c: Avoid shifting into sign bit of signed integers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-trivial@nongnu.org, Jan Kiszka , qemu-devel@nongnu.org, patches@linaro.org 23.08.2013 20:36, Peter Maydell wrote: > "0xf << 28" shifts right into the sign bit, since 0xf is a signed > integer. Use the 'U' suffix to force an unsigned shift to avoid > this undefined behaviour and a clang sanitizer warning. Thanks, applied to the trivial-patches queue. /mjt