From: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
To: Wang Shilong <wangshilong1991@gmail.com>
Cc: Josef Bacik <jbacik@fusionio.com>, linux-btrfs@vger.kernel.org
Subject: Re: Btrfs: separate out tests into their own directory V2
Date: Mon, 02 Sep 2013 09:13:05 +0800 [thread overview]
Message-ID: <5223E621.8060604@cn.fujitsu.com> (raw)
In-Reply-To: <5222db6d.y1rlQi1VIlwCf9La%wangshilong1991@gmail.com>
Sorry, please ignore this thread...
Thanks,
wang
On 09/01/2013 02:15 PM, Wang Shilong wrote:
> Hello, Using checkpatch.pl, i get the following warnings(errors):
> WARNING: kfree(NULL) is safe this check is probably not required
> #132: FILE: fs/btrfs/free-space-cache.c:3035:
> + if (map)
> + kfree(map);
>
> WARNING: line over 80 characters
> #882: FILE: fs/btrfs/tests/free-space-tests.c:211:
> + ret = test_add_free_space_entry(cache, 4 * 1024 * 1024, 1 * 1024 * 1024, 1);
>
> WARNING: line over 80 characters
> #927: FILE: fs/btrfs/tests/free-space-tests.c:256:
> + ret = test_add_free_space_entry(cache, 1 * 1024 * 1024, 4 * 1024 * 1024, 1);
>
> WARNING: line over 80 characters
> #947: FILE: fs/btrfs/tests/free-space-tests.c:276:
> + ret = test_add_free_space_entry(cache, 4 * 1024 * 1024, 4 * 1024 * 1024, 1);
>
> WARNING: line over 80 characters
> #953: FILE: fs/btrfs/tests/free-space-tests.c:282:
> + ret = test_add_free_space_entry(cache, 2 * 1024 * 1024, 2 * 1024 * 1024, 0);
>
> WARNING: line over 80 characters
> #1016: FILE: fs/btrfs/tests/free-space-tests.c:345:
> + ret = test_add_free_space_entry(cache, 1 * 1024 * 1024, 2 * 1024 * 1024, 1);
>
> WARNING: line over 80 characters
> #1022: FILE: fs/btrfs/tests/free-space-tests.c:351:
> + ret = test_add_free_space_entry(cache, 3 * 1024 * 1024, 1 * 1024 * 1024, 0);
>
> WARNING: line over 80 characters
> #1030: FILE: fs/btrfs/tests/free-space-tests.c:359:
> + test_msg("Error removing bitmap and extent overlapping %d\n", ret);
>
> total: 0 errors, 8 warnings, 997 lines checked
>
> patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> Thanks, Wang
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2013-09-02 1:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 6:15 Btrfs: separate out tests into their own directory V2 Wang Shilong
2013-09-02 1:13 ` Wang Shilong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5223E621.8060604@cn.fujitsu.com \
--to=wangsl.fnst@cn.fujitsu.com \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wangshilong1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.