All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhangfei <zhangfei.gao@linaro.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Vinod Koul'" <vinod.koul@intel.com>,
	"'Dan Williams'" <djbw@fb.com>,
	linux-kernel@vger.kernel.org,
	"'Kai Yang'" <jean.yangkai@huawei.com>
Subject: Re: [PATCH 2/2] dma: k3dma: use devm_ioremap_resource() instead of devm_request_and_ioremap()
Date: Mon, 02 Sep 2013 10:30:45 +0800	[thread overview]
Message-ID: <5223F855.8070503@linaro.org> (raw)
In-Reply-To: <005101cea77b$6fe297a0$4fa7c6e0$%han@samsung.com>

On 13-09-02 09:26 AM, Jingoo Han wrote:
> Use devm_ioremap_resource() because devm_request_and_ioremap() is
> obsoleted by devm_ioremap_resource().
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Thanks Jingoo for point out.

Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>

> ---
>   drivers/dma/k3dma.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/k3dma.c b/drivers/dma/k3dma.c
> index ef7bc85..a2c330f 100644
> --- a/drivers/dma/k3dma.c
> +++ b/drivers/dma/k3dma.c
> @@ -673,9 +673,9 @@ static int k3_dma_probe(struct platform_device *op)
>   	if (!d)
>   		return -ENOMEM;
>
> -	d->base = devm_request_and_ioremap(&op->dev, iores);
> -	if (!d->base)
> -		return -EADDRNOTAVAIL;
> +	d->base = devm_ioremap_resource(&op->dev, iores);
> +	if (IS_ERR(d->base))
> +		return PTR_ERR(d->base);
>
>   	of_id = of_match_device(k3_pdma_dt_ids, &op->dev);
>   	if (of_id) {
>


  reply	other threads:[~2013-09-02  2:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-02  1:23 [PATCH 1/2] dma: sh: use devm_ioremap_resource() instead of devm_request_and_ioremap() Jingoo Han
2013-09-02  1:25 ` PATCH 2/2] dma: k3dma: " Jingoo Han
2013-09-02  1:26 ` [PATCH " Jingoo Han
2013-09-02  2:30   ` zhangfei [this message]
2013-09-02  6:34 ` [PATCH 1/2] dma: sh: " Vinod Koul
2013-09-02 12:09   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5223F855.8070503@linaro.org \
    --to=zhangfei.gao@linaro.org \
    --cc=djbw@fb.com \
    --cc=jean.yangkai@huawei.com \
    --cc=jg1.han@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.