From: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nftables tool PATCH 2/5] src: Wrap netfilter hooks around human readable strings
Date: Mon, 02 Sep 2013 08:03:20 +0300 [thread overview]
Message-ID: <52241C18.1090906@linux.intel.com> (raw)
In-Reply-To: <20130830220557.GB5905@localhost>
Hi Pablo,
> This can be done better by checking this in the evaluation step, in
> chain_evaluate (you can reach the family via ctx).
Ok, a step before indeed.
At first I was planning to do that at parsing stage but couldn't reach
the chain's family.
> Moreover, you can store the hook as string in the parser. Then, in the
> evaluation step you validate that it is correct and convert it to
> numeric value. That will require two fields in the chain, one for the
> hookstr and one for hooknum.
Makes sense, though the struct chain will grow a bit then.
I will still validate the string at parsing stage to keep the error
reporting on that particular place.
Tomasz
next prev parent reply other threads:[~2013-09-02 5:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 8:33 [nftables tool PATCH 0/5] Easier base chain declaration Tomasz Bursztyka
2013-08-28 8:33 ` [nftables tool PATCH 1/5] src: Fix base chain print out Tomasz Bursztyka
2013-08-30 21:58 ` Pablo Neira Ayuso
2013-08-28 8:33 ` [nftables tool PATCH 2/5] src: Wrap netfilter hooks around human readable strings Tomasz Bursztyka
2013-08-30 22:05 ` Pablo Neira Ayuso
2013-09-02 5:03 ` Tomasz Bursztyka [this message]
2013-08-28 8:33 ` [nftables tool PATCH 3/5] syntax: Add priority keyword on base chain description Tomasz Bursztyka
2013-08-28 8:33 ` [nftables tool PATCH 4/5] src: Ensure given base chain type is a valid one Tomasz Bursztyka
2013-08-28 8:33 ` [nftables tool PATCH 5/5] tests: Update bate chain creation according to latest syntax changes Tomasz Bursztyka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52241C18.1090906@linux.intel.com \
--to=tomasz.bursztyka@linux.intel.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.