From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Len Brown <lenb@kernel.org>, "Rafael J. Wysocki" <rjw@sisk.pl>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] intel_idle: mark some functions with __init tag
Date: Mon, 02 Sep 2013 11:29:32 +0200 [thread overview]
Message-ID: <52245A7C.6070602@linaro.org> (raw)
In-Reply-To: <2017492.SHLf7BQHGW@amdc1032>
On 08/30/2013 12:27 PM, Bartlomiej Zolnierkiewicz wrote:
> intel_idle_probe() and intel_idle_cpuidle_driver_init() can be marked
> with __init tag as they are only called from intel_idle_init().
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Len Brown <lenb@kernel.org>
> ---
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> drivers/idle/intel_idle.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index 53b24f1..33e599e 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -490,7 +490,7 @@ MODULE_DEVICE_TABLE(x86cpu, intel_idle_ids);
> /*
> * intel_idle_probe()
> */
> -static int intel_idle_probe(void)
> +static int __init intel_idle_probe(void)
> {
> unsigned int eax, ebx, ecx;
> const struct x86_cpu_id *id;
> @@ -558,7 +558,7 @@ static void intel_idle_cpuidle_devices_uninit(void)
> * intel_idle_cpuidle_driver_init()
> * allocate, initialize cpuidle_states
> */
> -static int intel_idle_cpuidle_driver_init(void)
> +static int __init intel_idle_cpuidle_driver_init(void)
> {
> int cstate;
> struct cpuidle_driver *drv = &intel_idle_driver;
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2013-09-02 9:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 10:27 [PATCH 3/3] intel_idle: mark some functions with __init tag Bartlomiej Zolnierkiewicz
2013-09-02 9:29 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52245A7C.6070602@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.