From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGSG5-0003H1-NY for qemu-devel@nongnu.org; Mon, 02 Sep 2013 07:25:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGSFy-0004cn-81 for qemu-devel@nongnu.org; Mon, 02 Sep 2013 07:25:25 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47349 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGSFx-0004ce-UN for qemu-devel@nongnu.org; Mon, 02 Sep 2013 07:25:18 -0400 Message-ID: <5224759A.6070602@suse.de> Date: Mon, 02 Sep 2013 13:25:14 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1375057621-19961-1-git-send-email-afaerber@suse.de> In-Reply-To: <1375057621-19961-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-next for-next v2 0/6] PCI VMState cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Stefan Hajnoczi , Gerd Hoffmann , qemu-devel@nongnu.org, Juan Quintela Am 29.07.2013 02:26, schrieb Andreas F=C3=A4rber: > Hello Michael and Gerd, >=20 > As discussed, this series attempts to clean up PCIe devices fiddling wi= th > individual PCI VMStateFields. It is based on my qom-devices queue, cont= aining > changes to PCIe devices. >=20 > v2 has been changed to use VMStateField::field_exists instead of subsec= tions > and unifies PCI and PCIe. Making MSI-X such a conditional field affects= PCI, too, > now and therefore requires incompatible changes to VMXNET3 PCI NIC. >=20 > This has been successfully tested with a selection of PCI and PCIe devi= ces > on -machine pc (-machine q35 is unfortunately unmigratable due to ich9-= ahci) > and shows identically sized state files (for "exec:cat > pc-pci.state")= and > no immediate crashes. Not 1.6 material. Ping! Stefan requested researching a solution that doesn't break vmxnet3 migration compatibility, but previous patches are waiting for review. Andreas >=20 > A QOM follow-up RFC will be sent out shortly. >=20 > Regards, > Andreas >=20 > v1 -> v2: > * Prepended patches to drop VMSTATE_{PCI,PCIE}_DEVICE() arguments. > * Added patch to introduce VMSTATE_BUFFER_UNSAFE_INFO_TEST() macro. > * Unified PCI and PCIe VMStateDescriptions (mst). > * Instead of moving & turning into subsection, make AER log conditional= field. > * Instead of subsection, make MSI-X a conditional field. >=20 > Cc: Michael S. Tsirkin > Cc: Gerd Hoffmann > Cc: Stefan Hajnoczi > Cc: Juan Quintela >=20 > Andreas F=C3=A4rber (6): > pci: Simplify VMSTATE_PCI_DEVICE() macro > pci: Simplify VMSTATE_PCIE_DEVICE() macro > vmstate: Introduce VMSTATE_BUFFER_UNSAFE_INFO_TEST() > pci: Unify vmstate_{pci,pcie}_device > pci: Move vmstate_pcie_aer_log into vmstate_pci_device > pci: Move VMSTATE_MSIX() into vmstate_pci_device >=20 > hw/acpi/piix4.c | 2 +- > hw/audio/ac97.c | 2 +- > hw/audio/es1370.c | 2 +- > hw/audio/intel-hda.c | 2 +- > hw/char/serial-pci.c | 4 +-- > hw/char/tpci200.c | 2 +- > hw/display/cirrus_vga.c | 2 +- > hw/display/qxl.c | 2 +- > hw/display/vga-pci.c | 2 +- > hw/display/vmware_vga.c | 2 +- > hw/i2c/smbus_ich9.c | 2 +- > hw/ide/ich.c | 2 +- > hw/ide/pci.c | 2 +- > hw/isa/i82378.c | 2 +- > hw/isa/lpc_ich9.c | 2 +- > hw/isa/piix4.c | 2 +- > hw/isa/vt82c686.c | 4 +-- > hw/misc/ivshmem.c | 7 ++-- > hw/net/e1000.c | 2 +- > hw/net/eepro100.c | 2 +- > hw/net/ne2000.c | 2 +- > hw/net/pcnet-pci.c | 2 +- > hw/net/rtl8139.c | 2 +- > hw/net/vmxnet3.c | 29 +++------------ > hw/pci-bridge/ioh3420.c | 4 +-- > hw/pci-bridge/pci_bridge_dev.c | 2 +- > hw/pci-bridge/xio3130_downstream.c | 4 +-- > hw/pci-bridge/xio3130_upstream.c | 4 +-- > hw/pci-host/bonito.c | 2 +- > hw/pci-host/piix.c | 4 +-- > hw/pci-host/prep.c | 2 +- > hw/pci-host/q35.c | 2 +- > hw/pci/pci.c | 73 +++++++++++++++++++++++-------= -------- > hw/pci/pcie_aer.c | 1 + > hw/scsi/esp-pci.c | 2 +- > hw/scsi/lsi53c895a.c | 2 +- > hw/scsi/megasas.c | 2 +- > hw/scsi/vmw_pvscsi.c | 2 +- > hw/usb/hcd-ehci-pci.c | 2 +- > hw/usb/hcd-uhci.c | 2 +- > hw/usb/hcd-xhci.c | 3 +- > hw/virtio/virtio-pci.c | 19 +++++----- > hw/watchdog/wdt_i6300esb.c | 2 +- > hw/xen/xen_platform.c | 2 +- > include/hw/pci/msix.h | 7 ++-- > include/hw/pci/pci.h | 6 ++-- > include/hw/pci/pcie.h | 10 ------ > include/migration/vmstate.h | 6 +++- > 48 files changed, 116 insertions(+), 133 deletions(-) >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg