From: Paolo Bonzini <pbonzini@redhat.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>
Cc: kwolf@redhat.com, stefanha@gmail.com, Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH V11 1/5] throttle: Add a new throttling API implementing continuous leaky bucket.
Date: Mon, 02 Sep 2013 17:34:12 +0200 [thread overview]
Message-ID: <5224AFF4.30901@redhat.com> (raw)
In-Reply-To: <20130902101612.GA5073@irqsave.net>
Il 02/09/2013 12:16, Benoît Canet ha scritto:
>> If op_size is non-zero, iops limits are merely a fixed proportion of bps
>> > limits, which means the lower set of the two is applied and the higher skipped.
>> > I understand the amazon uses op_size like accounting for big IO requests, but
>> > we don't do it condionally on io size or anything here, so that once user sets
>> > op_size, it simply kicks either bps_{,rd,wr} or iops_{,rd,wr} out the game, is
>> > that true?
> It will combine with iops_{,rd,wr}.
I think what Fam asked is this:
what is the difference between bps=524288 and iops=1/op_size=524288?
And I think the answer should be that bs=524288 will allow many requests
up to 524288 bytes, while with iops all requests should be rounded up to
the op_size.
However, I think this is not what the code is doing right now, isn't it?
Paolo
next prev parent reply other threads:[~2013-09-02 15:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 16:39 [Qemu-devel] [PATCH V11 0/5] Continuous Leaky Bucket Throttling Benoît Canet
2013-09-01 16:39 ` [Qemu-devel] [PATCH V11 1/5] throttle: Add a new throttling API implementing continuous leaky bucket Benoît Canet
2013-09-02 3:08 ` Fam Zheng
2013-09-02 10:16 ` Benoît Canet
2013-09-02 15:34 ` Paolo Bonzini [this message]
2013-09-02 16:06 ` Benoît Canet
2013-09-01 16:39 ` [Qemu-devel] [PATCH V11 2/5] throttle: Add units tests Benoît Canet
2013-09-01 16:39 ` [Qemu-devel] [PATCH V11 3/5] block: Enable the new throttling code in the block layer Benoît Canet
2013-09-02 2:24 ` Fam Zheng
2013-09-02 10:19 ` Benoît Canet
2013-09-01 16:39 ` [Qemu-devel] [PATCH V11 4/5] block: Add support for throttling burst max in QMP and the command line Benoît Canet
2013-09-02 2:50 ` Fam Zheng
2013-09-02 11:49 ` Benoît Canet
2013-09-01 16:39 ` [Qemu-devel] [PATCH V11 5/5] block: Add iops_size to do the iops accounting for a given io size Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5224AFF4.30901@redhat.com \
--to=pbonzini@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.