All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nios2: change size_t to fix format warning for gcc 4.7.3
Date: Tue, 03 Sep 2013 11:14:18 +0800	[thread overview]
Message-ID: <5225540A.6070904@wytron.com.tw> (raw)
In-Reply-To: <1378175915-28288-1-git-send-email-thomas@wytron.com.tw>

Hi Mike,

On 09/03/2013 10:38 AM, Thomas Chou wrote:
> The gcc-4.7.3 in lastest nios2 toolchain generated lots of warning on
> type mismatch. So change typedef of size_t to unsigned int, followed
> those of arm and mips arch.
>
> spi_flash.c: In function 'spi_flash_read_write':
> spi_flash.c:42:3: warning: format '%zu' expects argument of type
>    'size_t', but argument 2 has type 'long unsigned int' [-Wformat]

I need help on this. I had a similar problem for cmd_sf in 20111214.

This patch works for gcc-4.7.3, but triggers warning for gcc-3.4.6 and 
gcc-4.1.2.


Before,

gcc-3.4.6 and gcc-4.1.2 got no warning.

gcc-4.7.2 got

spi_flash.c: In function 'spi_flash_read_write':
spi_flash.c:42:3: warning: format '%zu' expects argument of type 
'size_t', but argument 2 has type 'long unsigned int' [-Wformat]
spi_flash.c:48:4: warning: format '%zu' expects argument of type 
'size_t', but argument 2 has type 'long unsigned int' [-Wformat]
spi_flash.c: In function 'spi_flash_cmd_write_multi':
spi_flash.c:236:3: warning: format '%zu' expects argument of type 
'size_t', but argument 7 has type 'long unsigned int' [-Wformat]
cmd_nvedit.c: In function 'do_env_export':
cmd_nvedit.c:912:3: warning: format '%zX' expects argument of type 
'size_t', but argument 3 has type 'long unsigned int' [-Wformat]
cmd_nvedit.c: In function 'do_env_import':
cmd_nvedit.c:1029:3: warning: format '%zu' expects argument of type 
'size_t', but argument 2 has type 'long unsigned int' [-Wformat]
cmd_nvedit.c:1029:3: warning: format '%zX' expects argument of type 
'size_t', but argument 3 has type 'long unsigned int' [-Wformat]
cmd_sf.c: In function 'spi_flash_update_block':
cmd_sf.c:153:2: warning: format '%zx' expects argument of type 'size_t', 
but argument 4 has type 'long unsigned int' [-Wformat]
cmd_sf.c:158:3: warning: format '%zx' expects argument of type 'size_t', 
but argument 3 has type 'long unsigned int' [-Wformat]
cmd_sf.c: In function 'spi_flash_update':
cmd_sf.c:206:9: warning: format '%zu' expects argument of type 'size_t', 
but argument 2 has type 'long unsigned int' [-Wformat]
cmd_sf.c:224:9: warning: format '%zu' expects argument of type 'size_t', 
but argument 2 has type 'long unsigned int' [-Wformat]
cmd_sf.c:224:9: warning: format '%zu' expects argument of type 'size_t', 
but argument 3 has type 'long unsigned int' [-Wformat]
cmd_sf.c: In function 'do_spi_flash_read_write':
cmd_sf.c:279:10: warning: format '%zu' expects argument of type 
'size_t', but argument 2 has type 'long unsigned int' [-Wformat]
cmd_sf.c: In function 'do_spi_flash_erase':
cmd_sf.c:314:9: warning: format '%zu' expects argument of type 'size_t', 
but argument 2 has type 'long unsigned int' [-Wformat]
hashtable.c: In function 'hexport_r':
hashtable.c:605:2: warning: format '%zu' expects argument of type 
'size_t', but argument 5 has type 'long unsigned int' [-Wformat]
hashtable.c:661:5: warning: format '%zu' expects argument of type 
'size_t', but argument 2 has type 'long unsigned int' [-Wformat]
hashtable.c:661:5: warning: format '%zu' expects argument of type 
'size_t', but argument 3 has type 'long unsigned int' [-Wformat]
hashtable.c: In function 'himport_r':
hashtable.c:793:3: warning: format '%zu' expects argument of type 
'size_t', but argument 2 has type 'long unsigned int' [-Wformat]


After this patch,

gcc-4.7.2 got no warning,

gcc-3.4.6 and gcc-4.1.2 got warning,

spi_flash.c: In function `spi_flash_read_write':
spi_flash.c:42: warning: long unsigned int format, size_t arg (arg 2)
spi_flash.c:48: warning: long unsigned int format, size_t arg (arg 2)
spi_flash.c: In function `spi_flash_cmd_write_multi':
spi_flash.c:236: warning: long unsigned int format, size_t arg (arg 7)
cmd_nvedit.c: In function `do_env_export':
cmd_nvedit.c:912: warning: size_t format, unsigned int arg (arg 3)
cmd_nvedit.c: In function `do_env_import':
cmd_nvedit.c:1029: warning: long unsigned int format, size_t arg (arg 2)
cmd_nvedit.c:1029: warning: long unsigned int format, size_t arg (arg 3)
cmd_sf.c: In function `spi_flash_update_block':
cmd_sf.c:153: warning: long unsigned int format, size_t arg (arg 4)
cmd_sf.c:158: warning: long unsigned int format, size_t arg (arg 3)
cmd_sf.c: In function `spi_flash_update':
cmd_sf.c:224: warning: long unsigned int format, size_t arg (arg 2)
cmd_sf.c:224: warning: long unsigned int format, size_t arg (arg 3)
cmd_sf.c: In function `do_spi_flash_read_write':
cmd_sf.c:279: warning: size_t format, unsigned int arg (arg 2)
cmd_sf.c: In function `do_spi_flash_erase':
cmd_sf.c:314: warning: size_t format, unsigned int arg (arg 2)
hashtable.c: In function `hexport_r':
hashtable.c:605: warning: long unsigned int format, size_t arg (arg 5)
hashtable.c:661: warning: long unsigned int format, size_t arg (arg 2)
hashtable.c:661: warning: long unsigned int format, size_t arg (arg 3)
hashtable.c: In function `himport_r':
hashtable.c:793: warning: long unsigned int format, size_t arg (arg 2)

Any comments welcome.

Thomas Chou

  reply	other threads:[~2013-09-03  3:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-03  2:38 [U-Boot] [PATCH] nios2: change size_t to fix format warning for gcc 4.7.3 Thomas Chou
2013-09-03  3:14 ` Thomas Chou [this message]
2013-09-05 12:55   ` Thomas Chou
2013-09-05 12:56     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5225540A.6070904@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.