All of lore.kernel.org
 help / color / mirror / Atom feed
From: rmallon@gmail.com (Ryan Mallon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: ep93xx: Don't use modem interface on the second UART
Date: Tue, 03 Sep 2013 14:36:58 +1000	[thread overview]
Message-ID: <5225676A.3070803@gmail.com> (raw)
In-Reply-To: <1377786491-15759-1-git-send-email-ynezz@true.cz>

On 30/08/13 00:28, Petr ?tetiar wrote:
> Second UART doesn't have modem interface, so any attempt to use set_mctrl() it
> produce unwanted garbage on the line. There's no such 0x100 register offset
> for the second UART either.
> 
> Signed-off-by: Petr ?tetiar <ynezz@true.cz>
> Cc: Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ryan Mallon <rmallon@gmail.com>

Hi Petr,

Sorry for the late reply. Added to ep93xx-fixes.

Thanks,
~Ryan

> ---
>  arch/arm/mach-ep93xx/core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c
> index df8612f..3f12b88 100644
> --- a/arch/arm/mach-ep93xx/core.c
> +++ b/arch/arm/mach-ep93xx/core.c
> @@ -281,7 +281,7 @@ static AMBA_APB_DEVICE(uart1, "apb:uart1", 0x00041010, EP93XX_UART1_PHYS_BASE,
>  	{ IRQ_EP93XX_UART1 }, &ep93xx_uart_data);
>  
>  static AMBA_APB_DEVICE(uart2, "apb:uart2", 0x00041010, EP93XX_UART2_PHYS_BASE,
> -	{ IRQ_EP93XX_UART2 }, &ep93xx_uart_data);
> +	{ IRQ_EP93XX_UART2 }, NULL);
>  
>  static AMBA_APB_DEVICE(uart3, "apb:uart3", 0x00041010, EP93XX_UART3_PHYS_BASE,
>  	{ IRQ_EP93XX_UART3 }, &ep93xx_uart_data);
> 

      reply	other threads:[~2013-09-03  4:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-29 14:28 [PATCH] ARM: ep93xx: Don't use modem interface on the second UART Petr Štetiar
2013-09-03  4:36 ` Ryan Mallon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5225676A.3070803@gmail.com \
    --to=rmallon@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.