From: Felix Fietkau <nbd@openwrt.org>
To: Sujith Manoharan <sujith@msujith.org>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/4] initvals: Remove duplicate mapping for AR9485 arrays
Date: Tue, 03 Sep 2013 08:25:38 +0200 [thread overview]
Message-ID: <522580E2.2090501@openwrt.org> (raw)
In-Reply-To: <1378184318-1169-2-git-send-email-sujith@msujith.org>
On 2013-09-03 6:58 AM, Sujith Manoharan wrote:
> From: Sujith Manoharan <c_manoha@qca.qualcomm.com>
>
> Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Why did you make this change? At least the mac_postamble is still
identical, and with the other arrays you can just let the initvals tool
detect if mappings are duplicate or not.
- Felix
next prev parent reply other threads:[~2013-09-03 6:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 4:58 [PATCH 1/4] initvals: Add channel 14 initvals for AR9565 Sujith Manoharan
2013-09-03 4:58 ` [PATCH 2/4] initvals: Remove duplicate mapping for AR9485 arrays Sujith Manoharan
2013-09-03 6:25 ` Felix Fietkau [this message]
2013-09-03 6:48 ` Sujith Manoharan
2013-09-03 4:58 ` [PATCH 3/4] initvals: Add missing initval arrays for AR9485 Sujith Manoharan
2013-09-03 4:58 ` [PATCH 4/4] initvals: Update AR9485 1.1 initvals Sujith Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522580E2.2090501@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=sujith@msujith.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.