From: Adrian Hunter <adrian.hunter@intel.com>
To: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: latest perf code fails to parse existing data file
Date: Tue, 03 Sep 2013 09:40:14 +0300 [thread overview]
Message-ID: <5225844E.3090700@intel.com> (raw)
In-Reply-To: <5225051C.3030608@gmail.com>
On 03/09/13 00:37, David Ahern wrote:
> Arnaldo/Adrian:
>
> Latest acme core tree fails to parse an existing data file:
>
> $ perf trace -i perf.data
> 0x16b8 [0x40]: failed to process type: 1
> Failed to process events, error -22
I can't reproduce this. The following works:
$ perf --version
perf version 3.9.10-100.fc17.x86_64
$ sudo perf record -e raw_syscalls:* ls
...
$ tools/perf/perf --version
perf version 3.11.rc4.g31cd38
$ sudo tools/perf/perf script
...
$ sudo tools/perf/perf trace -i perf.data
...
>
> git bisect traced it to:
> $ git bisect bad
> 75562573bab35b129cfd342fc2bcf89da84a6644 is the first bad commit
> commit 75562573bab35b129cfd342fc2bcf89da84a6644
> Author: Adrian Hunter <adrian.hunter@intel.com>
> Date: Tue Aug 27 11:23:09 2013 +0300
>
> perf tools: Add support for PERF_SAMPLE_IDENTIFIER
>
> Enable parsing of samples with sample format bit PERF_SAMPLE_IDENTIFIER.
> In addition, if the kernel supports it, prefer it to selecting
> PERF_SAMPLE_ID thereby allowing non-matching sample types.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Mike Galbraith <efault@gmx.de>
> Cc: Namhyung Kim <namhyung@gmail.com>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Stephane Eranian <eranian@google.com>
> Link:
> http://lkml.kernel.org/r/1377591794-30553-8-git-send-email-adrian.hunter@intel.com
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> :040000 040000 7df758341904d77c391b90ab6b6bac97324d144a
> 93839bad8ab2e6d88d3037f3dc8fd721be5e8870 M tools
>
>
> If I revert the patch (and handle the missing __perf_evsel__sample_size in
> the tests code to get it to compile) it works -- file is parsed correctly.
>
> David
>
>
next prev parent reply other threads:[~2013-09-03 6:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 21:37 latest perf code fails to parse existing data file David Ahern
2013-09-03 6:40 ` Adrian Hunter [this message]
2013-09-03 12:50 ` David Ahern
2013-09-03 13:24 ` Adrian Hunter
2013-09-03 13:45 ` David Ahern
2013-09-04 17:54 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5225844E.3090700@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.