Re: [Qemu-devel] [PATCH v4 5/5] qemu-iotest: qcow2 image option amendment

[Max Reitz <mreitz@redhat.com>]

Am 02.09.2013 17:36, schrieb Kevin Wolf:
> Am 02.09.2013 um 12:04 hat Max Reitz geschrieben:
>> Add tests for qemu-img amend on qcow2 image files.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   tests/qemu-iotests/061     | 178 +++++++++++++++++++++++
>>   tests/qemu-iotests/061.out | 349 +++++++++++++++++++++++++++++++++++++++++++++
>>   tests/qemu-iotests/group   |   1 +
>>   3 files changed, 528 insertions(+)
>>   create mode 100755 tests/qemu-iotests/061
>>   create mode 100644 tests/qemu-iotests/061.out
>> +echo
>> +echo "=== Testing version upgrade and resize ==="
>> +echo
>> +IMGOPTS="compat=0.10" _make_test_img 64M
>> +$QEMU_IO -c "write -P 0x2a 42M 64k" "$TEST_IMG" | _filter_qemu_io
>> +./qcow2.py "$TEST_IMG" dump-header
>> +$QEMU_IMG amend -o "compat=1.1,lazy_refcounts=on,size=128M" "$TEST_IMG"
>> +./qcow2.py "$TEST_IMG" dump-header
>> +$QEMU_IO -c "read -P 0x2a 42M 64k" "$TEST_IMG" | _filter_qemu_io
>> +_check_test_img
> Your reference output isn't correct for this test: It expects a 64 MB
> image after the amend. Looks like there's a bug somewhere.
>
> Kevin
Oh, right, thanks for catching it!

Max