Re: [Qemu-devel] [PATCH 0/4] tcg/optimize: fixes and improvements

[Paolo Bonzini <pbonzini@redhat.com>]

Il 03/09/2013 08:27, Aurelien Jarno ha scritto:
> This patchset first fixes known-zero bits optimization so that it is
> actually used, and does some further optimizations for 32-bit ops and
> unsigned loads.
> 
> Aurelien Jarno (4):
>   tcg/optimize: fix know-zero bits optimization
>   tcg/optimize: fix known-zero bits for right shift ops
>   tcg/optimize: improve known-zero bits for 32-bit ops
>   tcg/optimize: add known-zero bits compute for load ops
> 
>  tcg/optimize.c |   48 +++++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 43 insertions(+), 5 deletions(-)
> 

Commit message 1 is a bit misleading, because the optimization still
works for quite a few cases involving constant and copy propagation.
However, I had the same patch in my queue, so I can't deny that there is
a problem. :)

Two questions:

1) should patch 2 be CCed to qemu-stable?

2) should patches 1 and 2 be inverted to avoid triggering bugs?

Paolo