From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Zhang Rui <rui.zhang@intel.com>
Cc: rjw@sisk.pl, linux-pm@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 02/27] gpiolib-acpi: convert acpi_evaluate_object() to acpi_execute_simple_method()
Date: Tue, 03 Sep 2013 10:42:57 +0300 [thread overview]
Message-ID: <52259301.30403@linux.intel.com> (raw)
In-Reply-To: <1378168335-22556-3-git-send-email-rui.zhang@intel.com>
On 09/03/2013 03:31 AM, Zhang Rui wrote:
> acpi_execute_simple_method() is a new ACPI API introduced to invoke
> an ACPI control method that has single integer parameter and no return value.
>
> Convert acpi_evaluate_object() to acpi_execute_simple_method()
> in drivers/gpio/gpiolib-acpi.c
>
> Signed-off-by: Zhang Rui<rui.zhang@intel.com>
> CC: Mathias Nyman<mathias.nyman@linux.intel.com>
> CC: Mika Westerberg<mika.westerberg@linux.intel.com>
> CC: Linus Walleij<linus.walleij@linaro.org>
> ---
> drivers/gpio/gpiolib-acpi.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> index 5c1ef2b..f2beb72 100644
> --- a/drivers/gpio/gpiolib-acpi.c
> +++ b/drivers/gpio/gpiolib-acpi.c
> @@ -73,15 +73,8 @@ static irqreturn_t acpi_gpio_irq_handler(int irq, void *data)
> static irqreturn_t acpi_gpio_irq_handler_evt(int irq, void *data)
> {
> struct acpi_gpio_evt_pin *evt_pin = data;
> - struct acpi_object_list args;
> - union acpi_object arg;
>
> - arg.type = ACPI_TYPE_INTEGER;
> - arg.integer.value = evt_pin->pin;
> - args.count = 1;
> - args.pointer =&arg;
> -
> - acpi_evaluate_object(evt_pin->evt_handle, NULL,&args, NULL);
> + acpi_execute_simple_method(evt_pin->evt_handle, NULL, evt_pin->pin);
>
> return IRQ_HANDLED;
> }
Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
next prev parent reply other threads:[~2013-09-03 7:38 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 0:31 [PATCH 00/27] ACPI AML helper conversion Zhang Rui
2013-09-03 0:31 ` [PATCH 01/27] olpc_xo15_sci: convert acpi_evaluate_object() to acpi_execute_simple_method() Zhang Rui
2013-09-03 0:31 ` [PATCH 02/27] gpiolib-acpi: " Zhang Rui
2013-09-03 7:17 ` Mika Westerberg
2013-09-03 7:42 ` Mathias Nyman [this message]
2013-09-17 12:55 ` Linus Walleij
2013-09-03 0:31 ` [PATCH 03/27] eeepc-laptop: " Zhang Rui
2013-09-03 0:31 ` [PATCH 04/27] fujitsu-laptop: " Zhang Rui
2013-09-03 13:11 ` Jonathan Woithe
2013-09-03 0:31 ` [PATCH 05/27] intel-rst: " Zhang Rui
2013-09-03 0:31 ` [PATCH 06/27] intel-smartconnect: " Zhang Rui
2013-09-03 0:31 ` [PATCH 07/27] topstar-laptop: " Zhang Rui
2013-09-03 0:31 ` [PATCH 08/27] toshiba_acpi: " Zhang Rui
2013-09-03 0:31 ` [PATCH 09/27] wmi: " Zhang Rui
2013-09-03 0:31 ` [PATCH 10/27] pcc_freq: convert acpi_get_handle() to acpi_has_method() Zhang Rui
2013-09-03 0:31 ` [PATCH 11/27] i915: intel_acpi: " Zhang Rui
2013-09-09 8:57 ` Daniel Vetter
2013-09-03 0:32 ` [PATCH 12/27] nouveau_acpi: " Zhang Rui
2013-09-03 0:32 ` [PATCH 13/27] acpi_pcihp: " Zhang Rui
2013-09-03 0:32 ` [PATCH 14/27] pci-acpi: " Zhang Rui
2013-09-03 0:32 ` [PATCH 15/27] fujitsu-laptop: " Zhang Rui
2013-09-03 13:11 ` Jonathan Woithe
2013-09-03 0:32 ` [PATCH 16/27] intel_menlow: " Zhang Rui
2013-09-03 0:32 ` [PATCH 17/27] sony-laptop: " Zhang Rui
2013-09-03 0:32 ` [PATCH 18/27] toshiba_acpi: " Zhang Rui
2013-09-03 0:32 ` [PATCH 19/27] wmi: " Zhang Rui
2013-09-03 0:32 ` [PATCH 20/27] pnpacpi: " Zhang Rui
2013-09-03 0:32 ` [PATCH 21/27] acpi_processor: convert acpi_evaluate_object() to acpi_evaluate_integer() Zhang Rui
2013-09-03 0:32 ` [PATCH 22/27] ACPI: dock: " Zhang Rui
2013-09-03 0:32 ` [PATCH 23/27] i2c-hid: " Zhang Rui
2013-09-04 10:14 ` Jiri Kosina
2013-09-06 8:17 ` Benjamin Tissoires
2013-09-03 0:32 ` [PATCH 24/27] fujitsu-laptop: " Zhang Rui
2013-09-03 13:12 ` Jonathan Woithe
2013-09-03 0:32 ` [PATCH 25/27] intel-rst: " Zhang Rui
2013-09-03 0:32 ` [PATCH 26/27] intel-smartconnect: " Zhang Rui
2013-09-03 0:32 ` [PATCH 27/27] toshiba_acpi: " Zhang Rui
2013-09-03 11:24 ` [PATCH 00/27] ACPI AML helper conversion Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52259301.30403@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@sisk.pl \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.