From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54730)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VGm9F-0002HJ-8U
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 04:39:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VGm99-0003R4-Jg
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 04:39:41 -0400
Received: from cantor2.suse.de ([195.135.220.15]:52245 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VGm99-0003Qy-Db
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 04:39:35 -0400
Message-ID: <5225A041.6080001@suse.de>
Date: Tue, 03 Sep 2013 10:39:29 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1378191564-6842-1-git-send-email-lig.fnst@cn.fujitsu.com>
In-Reply-To: <1378191564-6842-1-git-send-email-lig.fnst@cn.fujitsu.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] exec: avoid tcg_commit when kvm_enabled
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, qemu-devel <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <anthony@codemonkey.ws>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>

Am 03.09.2013 08:59, schrieb liguang:
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
>  exec.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>=20
> diff --git a/exec.c b/exec.c
> index 3ca9381..4509daa 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1824,7 +1824,9 @@ static void memory_map_init(void)
>      address_space_init(&address_space_io, system_io, "I/O");
> =20
>      memory_listener_register(&core_memory_listener, &address_space_mem=
ory);
> -    memory_listener_register(&tcg_memory_listener, &address_space_memo=
ry);
> +    if (!kvm_enabled()) {

if (tcg_enabled())? I'm guessing Xen and QTest don't need it either?

Andreas

> +        memory_listener_register(&tcg_memory_listener, &address_space_=
memory);
> +    }
>  }
> =20
>  MemoryRegion *get_system_memory(void)

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg