From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43414)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VGnKZ-00052G-Vz
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 05:55:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VGnKU-0001H8-1A
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 05:55:27 -0400
Message-ID: <5225B205.9020900@suse.de>
Date: Tue, 03 Sep 2013 11:55:17 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1378069165-10581-1-git-send-email-sw@weilnetz.de>
	<20130903085109.GE2683@dhcp-200-207.str.redhat.com>
In-Reply-To: <20130903085109.GE2683@dhcp-200-207.str.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] w32: Fix access to host devices
	(regression)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>, Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Alexander Graf <agraf@suse.de>, david.brenner3@gmail.com, qemu-stable@nongnu.org, qemu-devel <qemu-devel@nongnu.org>

Am 03.09.2013 10:51, schrieb Kevin Wolf:
> Am 01.09.2013 um 22:59 hat Stefan Weil geschrieben:
>> QEMU failed to open host devices like \\.\PhysicalDrive0 (first hard d=
isk)
>> since some time (commit 8a79380b8ef1b02d2abd705dd026a18863b09020?).
>>
>> Those devices use hdev_open which did not use the latest API for optio=
ns.
>> This resulted in a fatal runtime error:
>>
>>   Block protocol 'host_device' doesn't support the option 'filename'
>>
>> Duplicate code from raw_open to fix this.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>=20
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
>=20
>> ---
>>
>> This bug was reported by David Brenner.
>> It should be fixed in QEMU 1.6 as well.
>=20
> Cc: qemu-stable@nongnu.org
>=20
> (Ideally you'd also put this Cc line in your commit message.)

...and put the attribution as:

Reported-by: David Brenner <david.brenner3@gmail.com>

Maybe Stefan H. can still add that along with the Cc.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg