From: jinyoungp <jinyoungp@nvidia.com>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/8] regulator: aat2870: Convert to devm_regulator_register
Date: Tue, 3 Sep 2013 19:16:33 +0900 [thread overview]
Message-ID: <5225B701.6020502@nvidia.com> (raw)
In-Reply-To: <1378189140.4621.3.camel@phoenix>
Acked-by: Jinyoung Park <jinyoungp@nvidia.com>
On 09/03/2013 03:19 PM, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/aat2870-regulator.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/drivers/regulator/aat2870-regulator.c b/drivers/regulator/aat2870-regulator.c
> index 8b58763..1ca60ac 100644
> --- a/drivers/regulator/aat2870-regulator.c
> +++ b/drivers/regulator/aat2870-regulator.c
> @@ -176,7 +176,7 @@ static int aat2870_regulator_probe(struct platform_device *pdev)
> config.driver_data = ri;
> config.init_data = pdev->dev.platform_data;
>
> - rdev = regulator_register(&ri->desc, &config);
> + rdev = devm_regulator_register(&pdev->dev, &ri->desc, &config);
> if (IS_ERR(rdev)) {
> dev_err(&pdev->dev, "Failed to register regulator %s\n",
> ri->desc.name);
> @@ -187,21 +187,12 @@ static int aat2870_regulator_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int aat2870_regulator_remove(struct platform_device *pdev)
> -{
> - struct regulator_dev *rdev = platform_get_drvdata(pdev);
> -
> - regulator_unregister(rdev);
> - return 0;
> -}
> -
> static struct platform_driver aat2870_regulator_driver = {
> .driver = {
> .name = "aat2870-regulator",
> .owner = THIS_MODULE,
> },
> .probe = aat2870_regulator_probe,
> - .remove = aat2870_regulator_remove,
> };
>
> static int __init aat2870_regulator_init(void)
next prev parent reply other threads:[~2013-09-03 10:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 6:17 [PATCH 1/8] regulator: 88pm8607: Convert to devm_regulator_register Axel Lin
2013-09-03 6:19 ` [PATCH 2/8] regulator: aat2870: " Axel Lin
2013-09-03 10:16 ` jinyoungp [this message]
2013-09-03 6:20 ` [PATCH 3/8] regulator: ad5398: " Axel Lin
2013-09-03 6:22 ` [PATCH 4/8] regulator: as3711: " Axel Lin
2013-09-03 6:23 ` [PATCH 5/8] regulator: da903x: " Axel Lin
2013-09-03 6:24 ` [PATCH 6/8] regulator: da9052: " Axel Lin
2013-09-03 6:26 ` [PATCH 7/8] regulator: da9055: " Axel Lin
2013-09-03 6:27 ` [PATCH 8/8] regulator: fan53555: " Axel Lin
2013-09-03 9:26 ` [PATCH 1/8] regulator: 88pm8607: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5225B701.6020502@nvidia.com \
--to=jinyoungp@nvidia.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.