Re: [Qemu-devel] [PATCH] qmp: Documentation for BLOCK_IMAGE_CORRUPTED

[Max Reitz <mreitz@redhat.com>]

On 2013-09-03 15:39, Eric Blake wrote:
> On 09/02/2013 07:01 AM, Max Reitz wrote:
>> Add an appropriate entry describing this event and its parameters into
>> qmp-events.txt.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>> Follow-up to:
>>   - Add metadata overlap checks (series, v5); particularly patch 2
>>     (qcow2: Metadata overlap checks)
>> ---
>>   QMP/qmp-events.txt | 22 ++++++++++++++++++++++
>>   1 file changed, 22 insertions(+)
>>
>> diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
>> index 39b6016..6ff74d6 100644
>> --- a/QMP/qmp-events.txt
>> +++ b/QMP/qmp-events.txt
>> @@ -478,3 +478,25 @@ Example:
>>   
>>   { "event": "GUEST_PANICKED",
>>        "data": { "action": "pause" } }
>> +
>> +BLOCK_IMAGE_CORRUPTED
>> +---------------------
> The content is fine, but the location is not.  We are trying to keep
> this file sorted by event name, so this belongs between BALLOON_CHANGE
> and BLOCK_IO_ERROR.
Okay, I was wondering about something like that, but the GUEST_PANICED 
at the end signaled to me there would be no such sorting. ;-)

> As sorting is trivial, you can add this to your v2:
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
Thank you, I just sent v2.

Max