From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Tue, 03 Sep 2013 15:29:24 +0000 Subject: Re: [PATCH v3] KVM: PPC: Book3S HV: Reserve POWER8 space in get/set_one_reg Message-Id: <52260054.10807@suse.de> List-Id: References: <8097.1377842940@ale.ozlabs.ibm.com> <12855.1378169839@ale.ozlabs.ibm.com> <14028.1378170792@ale.ozlabs.ibm.com> In-Reply-To: <14028.1378170792@ale.ozlabs.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michael Neuling Cc: benh@kernel.crashing.org, Paul Mackerras , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org On 09/03/2013 03:13 AM, Michael Neuling wrote: > This reserves space in get/set_one_reg ioctl for the extra guest state > needed for POWER8. It doesn't implement these at all, it just reserves > them so that the ABI is defined now. > > A few things to note here: > > - This add *a lot* state for transactional memory. TM suspend mode, > this is unavoidable, you can't simply roll back all transactions and > store only the checkpointed state. I've added this all to > get/set_one_reg (including GPRs) rather than creating a new ioctl > which returns a struct kvm_regs like KVM_GET_REGS does. This means we > if we need to extract the TM state, we are going to need a bucket load > of IOCTLs. Hopefully most of the time this will not be needed as we > can look at the MSR to see if TM is active and only grab them when > needed. If this becomes a bottle neck in future we can add another > ioctl to grab all this state in one go. > > - The TM state is offset by 0x80000000. > > - For TM, I've done away with VMX and FP and created a single 64x128 bit > VSX register space. > > - I've left a space of 1 (at 0x9c) since Paulus needs to add a value > which applies to POWER7 as well. > > Signed-off-by: Michael Neuling Thanks, applied to kvm-ppc-queue. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH v3] KVM: PPC: Book3S HV: Reserve POWER8 space in get/set_one_reg Date: Tue, 03 Sep 2013 17:29:24 +0200 Message-ID: <52260054.10807@suse.de> References: <8097.1377842940@ale.ozlabs.ibm.com> <12855.1378169839@ale.ozlabs.ibm.com> <14028.1378170792@ale.ozlabs.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: benh@kernel.crashing.org, Paul Mackerras , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org To: Michael Neuling Return-path: In-Reply-To: <14028.1378170792@ale.ozlabs.ibm.com> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 09/03/2013 03:13 AM, Michael Neuling wrote: > This reserves space in get/set_one_reg ioctl for the extra guest state > needed for POWER8. It doesn't implement these at all, it just reserves > them so that the ABI is defined now. > > A few things to note here: > > - This add *a lot* state for transactional memory. TM suspend mode, > this is unavoidable, you can't simply roll back all transactions and > store only the checkpointed state. I've added this all to > get/set_one_reg (including GPRs) rather than creating a new ioctl > which returns a struct kvm_regs like KVM_GET_REGS does. This means we > if we need to extract the TM state, we are going to need a bucket load > of IOCTLs. Hopefully most of the time this will not be needed as we > can look at the MSR to see if TM is active and only grab them when > needed. If this becomes a bottle neck in future we can add another > ioctl to grab all this state in one go. > > - The TM state is offset by 0x80000000. > > - For TM, I've done away with VMX and FP and created a single 64x128 bit > VSX register space. > > - I've left a space of 1 (at 0x9c) since Paulus needs to add a value > which applies to POWER7 as well. > > Signed-off-by: Michael Neuling Thanks, applied to kvm-ppc-queue. Alex