From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH] tools: build debug qemu-xen in debug tools builds Date: Tue, 3 Sep 2013 17:24:40 +0100 Message-ID: <52260D48.9040102@citrix.com> References: <1378213979-11087-1-git-send-email-mattjd@gmail.com> <1378222354.17510.11.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1378222354.17510.11.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Matthew Daley , Stefano Stabellini , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 03/09/13 16:32, Ian Campbell wrote: > On Wed, 2013-09-04 at 01:12 +1200, Matthew Daley wrote: >> > When building tools in debug mode (debug=y), pass --enable-debug when >> > configuring qemu-xen to enable some debug support (namely, to prevent >> > symbols from being stripped). > This is from the installed binaries I suppose? Is this the only affect > or are there others? The other difference is not having -O2 in the CFLAGS for QEMU, I don't think there is anything else (beyond an debug option related to TCG which we don't use). > I'd like some feedback from the qemu maintainers about whether this is > an OK thing to do or not. Stefano/Anthony? > > Is it something we could consider doing unconditionally? I've run several time qemu-xen with --enable-debug without any issue, so I think it's fine to have this. -- Anthony PERARD