From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manfred Spraul Subject: Re: [PATCH] ipc/msg.c: Fix lost wakeup in msgsnd(). Date: Tue, 03 Sep 2013 18:33:09 +0200 Message-ID: <52260F45.6040702@colorfullife.com> References: <1378216808-2564-1-git-send-email-manfred@colorfullife.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: sedat.dilek@gmail.com, Greg KH Cc: Linus Torvalds , Andrew Morton , Davidlohr Bueso , Davidlohr Bueso , linux-next , LKML , Stephen Rothwell , linux-mm , Andi Kleen , Rik van Riel , Jonathan Gonzalez , Vineet Gupta List-Id: linux-next.vger.kernel.org Hi Sedat, On 09/03/2013 06:13 PM, Sedat Dilek wrote: > On Tue, Sep 3, 2013 at 4:00 PM, Manfred Spraul wrote: >> The check if the queue is full and adding current to the wait queue of pending >> msgsnd() operations (ss_add()) must be atomic. >> >> Otherwise: >> - the thread that performs msgsnd() finds a full queue and decides to sleep. >> - the thread that performs msgrcv() calls first reads all messages from the >> queue and then sleep, because the queue is empty. > reads -> sleeps Correct. >> - the msgrcv() calls do not perform any wakeups, because the msgsnd() task >> has not yet called ss_add(). >> - then the msgsnd()-thread first calls ss_add() and then sleeps. >> Net result: msgsnd() and msgrcv() both sleep forever. >> > I don't know what and why "net result" - net in sense of networking? http://en.wiktionary.org/wiki/net#Adjective I.e.: Ignore/remove the "Net". >> Observed with msgctl08 from ltp with a preemptible kernel. >> > ...on ARC arch (that sounds funny somehow). > >> Fix: Call ipc_lock_object() before performing the check. >> >> The patch also moves security_msg_queue_msgsnd() under ipc_lock_object: >> - msgctl(IPC_SET) explicitely mentions that it tries to expunge any pending >> operations that are not allowed anymore with the new permissions. >> If security_msg_queue_msgsnd() is called without locks, then there might be >> races. >> - it makes the patch much simpler. >> >> Reported-by: Vineet Gupta >> Signed-off-by: Manfred Spraul > I guess this is missing a "CC: stable" as Vineet reported against > Linux v3.11-rc7 (and should enter v3.11.1)? Yes. I didn't notice that Linus already released 3.11. -- Manfred > - Sedat - > >> --- >> ipc/msg.c | 12 +++++------- >> 1 file changed, 5 insertions(+), 7 deletions(-) >> >> diff --git a/ipc/msg.c b/ipc/msg.c >> index 9f29d9e..b65fdf1 100644 >> --- a/ipc/msg.c >> +++ b/ipc/msg.c >> @@ -680,16 +680,18 @@ long do_msgsnd(int msqid, long mtype, void __user *mtext, >> goto out_unlock1; >> } >> >> + ipc_lock_object(&msq->q_perm); >> + >> for (;;) { >> struct msg_sender s; >> >> err = -EACCES; >> if (ipcperms(ns, &msq->q_perm, S_IWUGO)) >> - goto out_unlock1; >> + goto out_unlock0; >> >> err = security_msg_queue_msgsnd(msq, msg, msgflg); >> if (err) >> - goto out_unlock1; >> + goto out_unlock0; >> >> if (msgsz + msq->q_cbytes <= msq->q_qbytes && >> 1 + msq->q_qnum <= msq->q_qbytes) { >> @@ -699,10 +701,9 @@ long do_msgsnd(int msqid, long mtype, void __user *mtext, >> /* queue full, wait: */ >> if (msgflg & IPC_NOWAIT) { >> err = -EAGAIN; >> - goto out_unlock1; >> + goto out_unlock0; >> } >> >> - ipc_lock_object(&msq->q_perm); >> ss_add(msq, &s); >> >> if (!ipc_rcu_getref(msq)) { >> @@ -730,10 +731,7 @@ long do_msgsnd(int msqid, long mtype, void __user *mtext, >> goto out_unlock0; >> } >> >> - ipc_unlock_object(&msq->q_perm); >> } >> - >> - ipc_lock_object(&msq->q_perm); >> msq->q_lspid = task_tgid_vnr(current); >> msq->q_stime = get_seconds(); >> >> -- >> 1.8.3.1 >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx121.postini.com [74.125.245.121]) by kanga.kvack.org (Postfix) with SMTP id 0480D6B0031 for ; Tue, 3 Sep 2013 12:33:14 -0400 (EDT) Received: by mail-bk0-f49.google.com with SMTP id r7so2206413bkg.22 for ; Tue, 03 Sep 2013 09:33:13 -0700 (PDT) Message-ID: <52260F45.6040702@colorfullife.com> Date: Tue, 03 Sep 2013 18:33:09 +0200 From: Manfred Spraul MIME-Version: 1.0 Subject: Re: [PATCH] ipc/msg.c: Fix lost wakeup in msgsnd(). References: <1378216808-2564-1-git-send-email-manfred@colorfullife.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: sedat.dilek@gmail.com, Greg KH Cc: Linus Torvalds , Andrew Morton , Davidlohr Bueso , Davidlohr Bueso , linux-next , LKML , Stephen Rothwell , linux-mm , Andi Kleen , Rik van Riel , Jonathan Gonzalez , Vineet Gupta Hi Sedat, On 09/03/2013 06:13 PM, Sedat Dilek wrote: > On Tue, Sep 3, 2013 at 4:00 PM, Manfred Spraul wrote: >> The check if the queue is full and adding current to the wait queue of pending >> msgsnd() operations (ss_add()) must be atomic. >> >> Otherwise: >> - the thread that performs msgsnd() finds a full queue and decides to sleep. >> - the thread that performs msgrcv() calls first reads all messages from the >> queue and then sleep, because the queue is empty. > reads -> sleeps Correct. >> - the msgrcv() calls do not perform any wakeups, because the msgsnd() task >> has not yet called ss_add(). >> - then the msgsnd()-thread first calls ss_add() and then sleeps. >> Net result: msgsnd() and msgrcv() both sleep forever. >> > I don't know what and why "net result" - net in sense of networking? http://en.wiktionary.org/wiki/net#Adjective I.e.: Ignore/remove the "Net". >> Observed with msgctl08 from ltp with a preemptible kernel. >> > ...on ARC arch (that sounds funny somehow). > >> Fix: Call ipc_lock_object() before performing the check. >> >> The patch also moves security_msg_queue_msgsnd() under ipc_lock_object: >> - msgctl(IPC_SET) explicitely mentions that it tries to expunge any pending >> operations that are not allowed anymore with the new permissions. >> If security_msg_queue_msgsnd() is called without locks, then there might be >> races. >> - it makes the patch much simpler. >> >> Reported-by: Vineet Gupta >> Signed-off-by: Manfred Spraul > I guess this is missing a "CC: stable" as Vineet reported against > Linux v3.11-rc7 (and should enter v3.11.1)? Yes. I didn't notice that Linus already released 3.11. -- Manfred > - Sedat - > >> --- >> ipc/msg.c | 12 +++++------- >> 1 file changed, 5 insertions(+), 7 deletions(-) >> >> diff --git a/ipc/msg.c b/ipc/msg.c >> index 9f29d9e..b65fdf1 100644 >> --- a/ipc/msg.c >> +++ b/ipc/msg.c >> @@ -680,16 +680,18 @@ long do_msgsnd(int msqid, long mtype, void __user *mtext, >> goto out_unlock1; >> } >> >> + ipc_lock_object(&msq->q_perm); >> + >> for (;;) { >> struct msg_sender s; >> >> err = -EACCES; >> if (ipcperms(ns, &msq->q_perm, S_IWUGO)) >> - goto out_unlock1; >> + goto out_unlock0; >> >> err = security_msg_queue_msgsnd(msq, msg, msgflg); >> if (err) >> - goto out_unlock1; >> + goto out_unlock0; >> >> if (msgsz + msq->q_cbytes <= msq->q_qbytes && >> 1 + msq->q_qnum <= msq->q_qbytes) { >> @@ -699,10 +701,9 @@ long do_msgsnd(int msqid, long mtype, void __user *mtext, >> /* queue full, wait: */ >> if (msgflg & IPC_NOWAIT) { >> err = -EAGAIN; >> - goto out_unlock1; >> + goto out_unlock0; >> } >> >> - ipc_lock_object(&msq->q_perm); >> ss_add(msq, &s); >> >> if (!ipc_rcu_getref(msq)) { >> @@ -730,10 +731,7 @@ long do_msgsnd(int msqid, long mtype, void __user *mtext, >> goto out_unlock0; >> } >> >> - ipc_unlock_object(&msq->q_perm); >> } >> - >> - ipc_lock_object(&msq->q_perm); >> msq->q_lspid = task_tgid_vnr(current); >> msq->q_stime = get_seconds(); >> >> -- >> 1.8.3.1 >> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org