From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VGvLf-0001Uh-9y for mharc-qemu-trivial@gnu.org; Tue, 03 Sep 2013 14:29:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGvLY-0001P5-7e for qemu-trivial@nongnu.org; Tue, 03 Sep 2013 14:29:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGvLR-0002ua-43 for qemu-trivial@nongnu.org; Tue, 03 Sep 2013 14:29:00 -0400 Received: from v220110690675601.yourvserver.net ([37.221.199.173]:37116) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGvLQ-0002uW-Td for qemu-trivial@nongnu.org; Tue, 03 Sep 2013 14:28:53 -0400 Received: from localhost (v220110690675601.yourvserver.net.local [127.0.0.1]) by v220110690675601.yourvserver.net (Postfix) with ESMTP id C542272819E4; Tue, 3 Sep 2013 20:28:50 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at weilnetz.de Received: from v220110690675601.yourvserver.net ([127.0.0.1]) by localhost (v220110690675601.yourvserver.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1KaZzTYHALUz; Tue, 3 Sep 2013 20:28:48 +0200 (CEST) Received: from [192.168.178.35] (p54AD8396.dip0.t-ipconnect.de [84.173.131.150]) by v220110690675601.yourvserver.net (Postfix) with ESMTPSA id 7B92972800FD; Tue, 3 Sep 2013 20:28:48 +0200 (CEST) Message-ID: <52262A5E.2010507@weilnetz.de> Date: Tue, 03 Sep 2013 20:28:46 +0200 From: Stefan Weil User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: qemu-devel References: <1377063869-16834-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1377063869-16834-1-git-send-email-sw@weilnetz.de> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 37.221.199.173 Cc: qemu-trivial Subject: Re: [Qemu-trivial] [PATCH] configure: Enable extra compiler warnings X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2013 18:29:05 -0000 Am 21.08.2013 07:44, schrieb Stefan Weil: > Compiler option -Wextra enables an additional set of compiler warnings. > > Some of these warnings were already enabled explicitly in QEMU: > -Wold-style-declaration, -Wtype-limits, -Wignored-qualifiers and > -Wempty-body are now redundant and can be removed. > > Others don't work with the current code and must be disabled to > avoid warnings: -Wno-missing-field-initializers, -Wno-override-init, > -Wno-sign-compare and -Wno-unused-parameter. > > Signed-off-by: Stefan Weil > --- > This is a rather old and long tested patch: I use -Wextra in my > QEMU builds for more than a year now. At least one bug was found > by using this warning level (see commit > b22dd1243f38286263d40496ce5298a8a7d96eea). > > My tests include Linux and Windows hosts (gcc), but not BSD based hosts, > so maybe those hosts might need additional code fixes. > clang reports lots of -Wunused-value warnings. > > Regards, > Stefan > > configure | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) Ping? I'd appreciate getting this patch committed. Is it trivial enough for qemu-trivial? Stefan See also http://patchwork.ozlabs.org/patch/268687/ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGvLV-0001O6-8r for qemu-devel@nongnu.org; Tue, 03 Sep 2013 14:29:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGvLQ-0002uM-Dm for qemu-devel@nongnu.org; Tue, 03 Sep 2013 14:28:57 -0400 Received: from [2a03:4000:1::4e2f:c7ac:d] (port=35419 helo=v220110690675601.yourvserver.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGvLQ-0002u3-79 for qemu-devel@nongnu.org; Tue, 03 Sep 2013 14:28:52 -0400 Message-ID: <52262A5E.2010507@weilnetz.de> Date: Tue, 03 Sep 2013 20:28:46 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1377063869-16834-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1377063869-16834-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] configure: Enable extra compiler warnings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel Cc: qemu-trivial Am 21.08.2013 07:44, schrieb Stefan Weil: > Compiler option -Wextra enables an additional set of compiler warnings. > > Some of these warnings were already enabled explicitly in QEMU: > -Wold-style-declaration, -Wtype-limits, -Wignored-qualifiers and > -Wempty-body are now redundant and can be removed. > > Others don't work with the current code and must be disabled to > avoid warnings: -Wno-missing-field-initializers, -Wno-override-init, > -Wno-sign-compare and -Wno-unused-parameter. > > Signed-off-by: Stefan Weil > --- > This is a rather old and long tested patch: I use -Wextra in my > QEMU builds for more than a year now. At least one bug was found > by using this warning level (see commit > b22dd1243f38286263d40496ce5298a8a7d96eea). > > My tests include Linux and Windows hosts (gcc), but not BSD based hosts, > so maybe those hosts might need additional code fixes. > clang reports lots of -Wunused-value warnings. > > Regards, > Stefan > > configure | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) Ping? I'd appreciate getting this patch committed. Is it trivial enough for qemu-trivial? Stefan See also http://patchwork.ozlabs.org/patch/268687/