From: huhaiyan@huawei.com (Haiyan Hu)
Subject: [PATCH] NVMe: Avoid caculate cq head doorbel in nvme_process_cq()
Date: Wed, 4 Sep 2013 17:15:51 +0800 [thread overview]
Message-ID: <5226FA47.10205@huawei.com> (raw)
In-Reply-To: <20130903155316.GY4707@linux.intel.com>
On 2013/9/3 23:53, Matthew Wilcox wrote:
> On Mon, Sep 02, 2013@06:49:34AM +0000, Huhaiyan (haiyan) wrote:
>> We use 2 pointers, one for sq tail doorbell, the other for cq head doorbell in struct nvme_queue, to avoid calculate cq head doorbell in nvme_process_cq().
>> This change can reduce latency for the admin/io command.
>
> Have you been able to measure a difference? If so, can you share
> relative numbers?
>
Sorry for my inaccurate description.
Our test data shows that this patch does not change cmd process latency.
But I think it can improve code efficiency, maybe a little.
In addition, the format of the patch I sent is corrupted.
I will resend it later.
Thank you.
next prev parent reply other threads:[~2013-09-04 9:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.3257.1377730793.1059.linux-nvme@lists.infradead.org>
2013-09-02 6:49 ` [PATCH] NVMe: Avoid caculate cq head doorbel in nvme_process_cq() Huhaiyan (haiyan)
2013-09-03 15:53 ` Matthew Wilcox
2013-09-04 9:15 ` Haiyan Hu [this message]
2013-09-04 16:51 ` Matthew Wilcox
2013-09-05 8:55 ` Haiyan Hu
2013-09-05 19:28 ` Matthew Wilcox
[not found] <A103C806EC8D6E46A0D950DAA4D118D1400E0067@szxeml558-mbx.china.huawei.com>
2013-09-02 7:00 ` Qiang Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5226FA47.10205@huawei.com \
--to=huhaiyan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.