From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH 0/3] kvm tools: remove periodic tick
Date: Wed, 04 Sep 2013 10:58:26 +0100
Message-ID: <52270442.2010605@arm.com>
References: <1378231855-13834-1-git-send-email-jonathan.austin@arm.com> <5226FC02.4060404@iki.fi>
Mime-Version: 1.0
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: 8BIT
Cc: Jonathan Austin <Jonathan.Austin@arm.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"penberg@kernel.org" <penberg@kernel.org>,
	Will Deacon <Will.Deacon@arm.com>,
	Matt Evans <Matt.Evans@arm.com>
To: Pekka Enberg <penberg@iki.fi>
Return-path: <kvm-owner@vger.kernel.org>
Received: from service87.mimecast.com ([91.220.42.44]:37189 "EHLO
	service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S934478Ab3IDJ6a convert rfc822-to-8bit (ORCPT
	<rfc822;kvm@vger.kernel.org>); Wed, 4 Sep 2013 05:58:30 -0400
In-Reply-To: <5226FC02.4060404@iki.fi>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 04/09/13 10:23, Pekka Enberg wrote:

Hi Pekka,

> On 9/3/13 9:10 PM, Jonathan Austin wrote:
>> This patch series removes kvm tool's periodic tick function in favour of a
>> thread that blocks waiting for input. The paths used for handling input are the
>> same as when using a periodic tick, but they're not called unless there is
>> actually input to be processed.
>>
>> On extremely slow platforms (eg FPGAs) the overhead involved in handling the
>> timer tick means it is possible to make progress at all inside the VM! This
>> patch addresses this problem.
>>
>> In doing this there are a number of small tidyups/cleanups that made sense, too:
>> - Use a #define for maximum number of term devices
>> - Refactor the method by which the virtio console handles input in order not to
>>    - handle input too early
>>    - handle input multiple times if the worker thread didn't immediately start
>>      work.
>> - Rename the periodic_poll function to reflect the functional change
>>
>> Jonathan Austin (3):
>>    kvm tools: use #define for maximum number of terminal devices
>>    kvm tools: remove periodic tick in favour of a polling thread
>>    kvm tools: stop virtio console doing unnecessary input handling
>>
>>   tools/kvm/arm/kvm.c         |    2 +-
>>   tools/kvm/builtin-run.c     |   13 -----------
>>   tools/kvm/include/kvm/kvm.h |    2 +-
>>   tools/kvm/kvm.c             |   50 -------------------------------------------
>>   tools/kvm/powerpc/kvm.c     |    2 +-
>>   tools/kvm/term.c            |   38 +++++++++++++++++++++++++++++---
>>   tools/kvm/virtio/console.c  |   23 +++++++++++++++++---
>>   tools/kvm/x86/kvm.c         |    2 +-
>>   8 files changed, 59 insertions(+), 73 deletions(-)
> 
> Seems reasonable to me. Marc, Will?

With the nits I mentioned earlier addressed, I'm happy to give my
"Acked-by: Marc Zyngier <marc.zyngier@arm.com>".

I must also mention than I've been using an earlier version of this
patch series, and that my test rig has been much happier since... ;-)

Cheers,

	M.
-- 
Jazz is not dead. It just smells funny...