From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: Don't set the ACTLR SMP bit for 64 bit guests Date: Wed, 04 Sep 2013 14:37:52 +0100 Message-ID: <522737B0.5000706@linaro.org> References: <1377797283-19954-1-git-send-email-julien.grall@linaro.org> <1378223775.17510.23.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1378223775.17510.23.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, patches@linaro.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 09/03/2013 04:56 PM, Ian Campbell wrote: > On Thu, 2013-08-29 at 18:28 +0100, Julien Grall wrote: >> The ACTLR register is implementation defined. The SMP bit is CA15 and CA7 >> specific. Also replace ACTLR_CA15_SMP by ACTLR_V7_SMP. >> >> Signed-off-by: Julien Grall > > I'm afraid this breaks the arm64 build: > domain.c: In function 'vcpu_initialise': > domain.c:482:30: error: 'ACTLR_V7_SMP' undeclared (first use in this function) > domain.c:482:30: note: each undeclared identifier is reported only once for eac > h function it appears in > > I'm not sure it is worth putting *that* much effort into a CA15/CA7 > kernel as a 32-bit guest on a 64-bit processor, at least not right now. > The interesting use case of this support is really a 32-bit kernel which > is aware that it is running in AArch32 EL1 on a 64-bit processor (i.e. > knows about the 64-bit processors implementation specific stuff) > > How about moving this into a proc info hook, or just ifdeffing it for > 32-bit? The first solution sounds better. I will rewrite the patch to add a proc info hook. -- Julien Grall