From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47887)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VHE4N-000841-DU
	for qemu-devel@nongnu.org; Wed, 04 Sep 2013 10:28:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VHE4I-0001NK-SR
	for qemu-devel@nongnu.org; Wed, 04 Sep 2013 10:28:31 -0400
Received: from mail-qe0-x22a.google.com ([2607:f8b0:400d:c02::22a]:40374)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VHE4I-0001NF-Ik
	for qemu-devel@nongnu.org; Wed, 04 Sep 2013 10:28:26 -0400
Received: by mail-qe0-f42.google.com with SMTP id 1so78075qec.15
	for <qemu-devel@nongnu.org>; Wed, 04 Sep 2013 07:28:25 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52274385.9060900@twiddle.net>
Date: Wed, 04 Sep 2013 07:28:21 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1378276653-18311-1-git-send-email-lig.fnst@cn.fujitsu.com>
In-Reply-To: <1378276653-18311-1-git-send-email-lig.fnst@cn.fujitsu.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] exec: do tcg_commit only when
	tcg_enabled
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>

On 09/03/2013 11:37 PM, liguang wrote:
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
>  exec.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/exec.c b/exec.c
> index 3ca9381..2170295 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1824,7 +1824,9 @@ static void memory_map_init(void)
>      address_space_init(&address_space_io, system_io, "I/O");
>  
>      memory_listener_register(&core_memory_listener, &address_space_memory);
> -    memory_listener_register(&tcg_memory_listener, &address_space_memory);
> +    if (tcg_enabled()) {
> +        memory_listener_register(&tcg_memory_listener, &address_space_memory);
> +    }
>  }
>  
>  MemoryRegion *get_system_memory(void)
> 

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~