From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHEAk-0003B6-DA for qemu-devel@nongnu.org; Wed, 04 Sep 2013 10:35:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHEAd-00033h-1i for qemu-devel@nongnu.org; Wed, 04 Sep 2013 10:35:06 -0400 Received: from thoth.sbs.de ([192.35.17.2]:16918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHEAc-00033X-OP for qemu-devel@nongnu.org; Wed, 04 Sep 2013 10:34:58 -0400 Message-ID: <5227450E.3050902@siemens.com> Date: Wed, 04 Sep 2013 16:34:54 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1378304540-1431-1-git-send-email-ottlik@fzi.de> <52274357.6010509@redhat.com> In-Reply-To: <52274357.6010509@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC] Do not set SO_REUSEADDR on Windows List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Sebastian Ottlik , Michael Tokarev , qemu-devel@nongnu.org, Stefan Hajnoczi , Anthony Liguori On 2013-09-04 16:27, Paolo Bonzini wrote: > Il 04/09/2013 16:22, Sebastian Ottlik ha scritto: >> This patchset disabels all use of SO_REUSEADDR on Windows. On Windows systems >> the default behavior is equivalent to SO_REUSEADDR on other operating >> systems. SO_REUSEADDR can still be set but results in undesired bahvior >> instead. It may even lead to situations were system behavior is >> unspecified. More information on this can be found at: >> http://msdn.microsoft.com/en-us/library/windows/desktop/ms740621.aspx >> >> I originally encountered this issue when accidentally launching two QEMU >> instances with identical GDB ports at the same time. In which case QEMU won't >> fail as one might expect. I am sending this as RFC as I A) only checked that >> this fixes issues for the GDB server and B) am not sure if this is the correct >> format for this patchset. >> >> gdbstub: do not set SO_REUSEADDR on Windows >> net: do not set SO_REUSEADDR on Windows >> slirp: do not set SO_REUSEADDR on Windows >> util: do not set SO_REUSEADDR on Windows > > Makes sense. > > Can you make a different patch that introduces a new function > qemu_set_reuseaddr is include/qemu/sockets.h & util/oslib-*, and makes > it a stub for Windows? > > This way we don't have a proliferation of #ifs. Yeah, this is definitely better then. IIRC, Michael has some version of patch 3 in his queue right now - should be dropped in this light. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux