From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53718)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ottlik@fzi.de>) id 1VHEV2-0002Kn-6D
	for qemu-devel@nongnu.org; Wed, 04 Sep 2013 10:56:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ottlik@fzi.de>) id 1VHEUu-00013z-Ao
	for qemu-devel@nongnu.org; Wed, 04 Sep 2013 10:56:04 -0400
Received: from ex-e-2.perimeter.fzi.de ([141.21.8.251]:26172)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ottlik@fzi.de>) id 1VHEUt-00013u-TB
	for qemu-devel@nongnu.org; Wed, 04 Sep 2013 10:55:56 -0400
Message-ID: <52274516.4070000@fzi.de>
Date: Wed, 4 Sep 2013 16:35:02 +0200
From: Sebastian Ottlik <ottlik@fzi.de>
MIME-Version: 1.0
References: <1378304540-1431-1-git-send-email-ottlik@fzi.de>
	<52274357.6010509@redhat.com>
In-Reply-To: <52274357.6010509@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC] Do not set SO_REUSEADDR on Windows
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On 04.09.2013 16:27, Paolo Bonzini wrote:
> Il 04/09/2013 16:22, Sebastian Ottlik ha scritto:
>> This patchset disabels all use of SO_REUSEADDR on Windows. On Windows systems
>> the default behavior is equivalent to SO_REUSEADDR on other operating
>> systems. SO_REUSEADDR can still be set but results in undesired bahvior
>> instead. It may even lead to situations were system behavior is
>> unspecified. More information on this can be found at:
>> http://msdn.microsoft.com/en-us/library/windows/desktop/ms740621.aspx
>>
>> I originally encountered this issue when accidentally launching two QEMU
>> instances with identical GDB ports at the same time. In which case QEMU won't
>> fail as one might expect. I am sending this as RFC as I A) only checked that
>> this fixes issues for the GDB server and B) am not sure if this is the correct
>> format for this patchset.
>>
>> gdbstub: do not set SO_REUSEADDR on Windows
>> net: do not set SO_REUSEADDR on Windows
>> slirp: do not set SO_REUSEADDR on Windows
>> util: do not set SO_REUSEADDR on Windows
> Makes sense.
>
> Can you make a different patch that introduces a new function
> qemu_set_reuseaddr is include/qemu/sockets.h & util/oslib-*, and makes
> it a stub for Windows?
>
> This way we don't have a proliferation of #ifs.
>
> Paolo
Sounds like a much cleaner approach. I will wait to see if there is more 
feedback and then submit a new version including your suggestion.