From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MTD: atmel_nand: support for software BCH ECC
Date: Wed, 04 Sep 2013 17:15:14 +0200 [thread overview]
Message-ID: <52274E82.6030300@gmail.com> (raw)
In-Reply-To: <52272BB7.8050900@gmail.com>
Hi Bo,
On 09/04/2013 02:46 PM, Bo Shen wrote:
> On 9/4/2013 8:30 PM, Andreas Bie?mann wrote:
>>> >Yes, we need libbch.
>>> >
>>> >If we really want to enable software BCH support. It also need add
>>> >following two options in board configuration file.
>>> >---8>---
>>> >#define CONFIG_NAND_ECC_BCH
>>> >#define CONFIG_BCH
>>> >---<8---
>>> >
>>> >So, this patch give us option to enable software BCH.
>> got it. So the NAND_ECC_BCH is the adoption for the SW BCH correction in
>> mtd layer. I understand that this would be helpful for at91 SoC without
>> PMECC HW. But there is no user currently, so I hesitate to apply this.
>
> Frankly, there is no EK boards from Atmel use software BCH now, however,
> a lot of customers use NAND with 224 bytes OOB, can not use software
> ECC, they need use software BCH.
I understand this. But it will be a piece of dead code until a user of
it would be submitted.
> So, I think it is better to apply this patch. If it will break the rule
> of u-boot, then I think we can wait real user in u-boot need this and
> then apply this patch.
I'd like to hear Scott's comment on that.
Best regards
Andreas Bie?mann
next prev parent reply other threads:[~2013-09-04 15:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 14:54 [U-Boot] [PATCH] MTD: atmel_nand: support for software BCH ECC Bo Shen
2013-09-04 10:23 ` Andreas Bießmann
2013-09-04 12:11 ` Bo Shen
2013-09-04 12:30 ` Andreas Bießmann
2013-09-04 12:46 ` Bo Shen
2013-09-04 15:15 ` Andreas Bießmann [this message]
2013-09-04 19:44 ` Scott Wood
2013-09-05 6:28 ` Andreas Bießmann
2013-09-05 17:25 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52274E82.6030300@gmail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.