From: Nishanth Menon <nm@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Sachin Kamat <sachin.kamat@linaro.org>,
<linux-kernel@vger.kernel.org>, <ldewangan@nvidia.com>,
<gg@slimlogic.co.uk>, <yong.shen@linaro.org>,
<s.hauer@pengutronix.de>, <marek.vasut@gmail.com>,
<Nancy.Chen@freescale.com>
Subject: Re: [PATCH 7/7] regulator: ti-abb: Use devm_regulator_register
Date: Wed, 4 Sep 2013 10:15:43 -0500 [thread overview]
Message-ID: <52274E9F.4050708@ti.com> (raw)
In-Reply-To: <20130904151241.GB10849@sirena.org.uk>
On 09/04/2013 10:12 AM, Mark Brown wrote:
> On Wed, Sep 04, 2013 at 08:27:56AM -0500, Nishanth Menon wrote:
>> On 09/04/2013 01:31 AM, Sachin Kamat wrote:
>
>>> abb = devm_kzalloc(dev, sizeof(struct ti_abb), GFP_KERNEL);
>>> - if (!abb) {
>>> - dev_err(dev, "%s: Unable to allocate ABB struct\n", __func__);
>>> - ret = -ENOMEM;
>>> - goto err;
>>> - }
>>> + if (!abb)
>>> + return -ENOMEM;
>
>> here.
>
> kzalloc() complains loudly when it fails, there's been a general thing
> for removing the per-device logs as redundant.
>
True, but for the remaining, I do not thing it kind of helps to quiet
things up.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2013-09-04 15:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 6:30 [PATCH 1/7] regulator: anatop-regulator: Use devm_regulator_register Sachin Kamat
2013-09-04 6:30 ` [PATCH 2/7] regulator: isl6271a-regulator: " Sachin Kamat
2013-09-04 14:26 ` Marek Vasut
2013-09-04 6:30 ` [PATCH 3/7] regulator: mc13783: " Sachin Kamat
2013-09-04 14:27 ` Marek Vasut
2013-09-04 6:31 ` [PATCH 4/7] regulator: mc13892: " Sachin Kamat
2013-09-04 14:29 ` Marek Vasut
2013-09-04 6:31 ` [PATCH 5/7] regulator: palmas: " Sachin Kamat
2013-09-04 14:32 ` Marek Vasut
2013-09-04 15:14 ` Sachin Kamat
2013-09-04 6:31 ` [PATCH 6/7] regulator: rc5t583: " Sachin Kamat
2013-09-04 14:33 ` Marek Vasut
2013-09-04 6:31 ` [PATCH 7/7] regulator: ti-abb: " Sachin Kamat
2013-09-04 13:27 ` Nishanth Menon
2013-09-04 15:12 ` Mark Brown
2013-09-04 15:15 ` Nishanth Menon [this message]
2013-09-04 16:26 ` Sachin Kamat
2013-09-04 16:33 ` Nishanth Menon
2013-09-04 16:48 ` Sachin Kamat
2013-09-04 17:00 ` Nishanth Menon
2013-09-04 18:03 ` Mark Brown
2013-09-04 9:49 ` [PATCH 1/7] regulator: anatop-regulator: " Mark Brown
2013-09-04 14:25 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52274E9F.4050708@ti.com \
--to=nm@ti.com \
--cc=Nancy.Chen@freescale.com \
--cc=broonie@kernel.org \
--cc=gg@slimlogic.co.uk \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=sachin.kamat@linaro.org \
--cc=yong.shen@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.