All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Asleson <tasleson@redhat.com>
To: lvm-devel@redhat.com
Subject: lvm2app and handle modifications during error conditions
Date: Wed, 04 Sep 2013 15:23:00 -0500	[thread overview]
Message-ID: <522796A4.1010807@redhat.com> (raw)

While working on a VG reduce bug in lvm2app it became very apparent that
in general when a user of a library runs into an error condition that
they should discard whatever VG/PV/LV handle they passed in to the call
and fetch a new one.  This is because the code base modifies the
structures during processing and if we fail we don't restore them.
Sometimes the structures are modified before we are even done checking
preconditions.  This isn't a problem when running as a command line as
when we exit all in flight changes are lost.

Does anyone have a simple solution to address this or is the best we can
do is educate library users with some updated documentation?

Thanks,
Tony



                 reply	other threads:[~2013-09-04 20:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=522796A4.1010807@redhat.com \
    --to=tasleson@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.