From: Daniel Borkmann <dborkman@redhat.com>
To: Dave Jones <davej@redhat.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [rfc] suspicious indentation in do_tcp_setsockopt
Date: Thu, 05 Sep 2013 09:42:44 +0200 [thread overview]
Message-ID: <522835F4.1040205@redhat.com> (raw)
In-Reply-To: <20130905044318.GA22806@redhat.com>
On 09/05/2013 06:43 AM, Dave Jones wrote:
> On Thu, Sep 05, 2013 at 12:39:07AM -0400, David Miller wrote:
> > From: Dave Jones <davej@redhat.com>
> > Date: Thu, 5 Sep 2013 00:20:45 -0400
> >
> > > What's the intent here ?
> >
> > This stuff is great, do you have a script that looks for this false
> > indentation pattern?
>
> Coverity. I'm doing daily builds with it now, in the hope of trying
> to catch things faster, but there's a *ton* of old stuff in there
> like this that needs sorting through, because it seems to have strange
> of notions of what a 'new' bug is.
Right, it seems 'new' is just newly *detected*, not necessarily newly
introduced in recent code.
> Dave
next prev parent reply other threads:[~2013-09-05 7:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 4:20 [rfc] suspicious indentation in do_tcp_setsockopt Dave Jones
2013-09-05 4:39 ` David Miller
2013-09-05 4:43 ` Dave Jones
2013-09-05 4:53 ` Joe Perches
2013-09-05 7:42 ` Daniel Borkmann [this message]
2013-09-05 4:43 ` Joe Perches
2013-09-05 17:24 ` Neal Cardwell
2013-09-05 17:34 ` Yuchung Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522835F4.1040205@redhat.com \
--to=dborkman@redhat.com \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.