All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Fam Zheng <famz@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH 5/6] module: load modules at start
Date: Thu, 05 Sep 2013 15:49:24 +0400	[thread overview]
Message-ID: <52286FC4.70505@msgid.tls.msk.ru> (raw)
In-Reply-To: <1378376448-29036-6-git-send-email-famz@redhat.com>

05.09.2013 14:20, Fam Zheng wrote:
> Add module_load_all to load all DSO modules under:
>     /usr/lib/qemu/block/
>     /usr/lib/qemu/net/
>     /usr/lib/qemu/ui/
> when starting process.

NACK.

This is wrong, as has been mentioned already.
For example, you can't expect to load ui/*
from qemu-img, because qemu-img provides no
symbols needed to link ui stuff.

Much better approach is to hook this stuff into
object/module registration framework, in module.c.
And either load every object of a given kind at
the init time, or try to load it at lookup time
if the requested object isn't found in current
list.

I implemented this approach in my tree more than
a month ago.

Thanks,

/mjt

  parent reply	other threads:[~2013-09-05 11:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 10:20 [Qemu-devel] [RFC PATCH 0/6] Shared Library Module Support Fam Zheng
2013-09-05 10:20 ` [Qemu-devel] [RFC PATCH 1/6] make.rule: fix $(obj) to a real relative path Fam Zheng
2013-09-06  9:41   ` Paolo Bonzini
2013-09-05 10:20 ` [Qemu-devel] [RFC PATCH 2/6] rule.mak: allow per object cflags and libs Fam Zheng
2013-09-05 10:20 ` [Qemu-devel] [RFC PATCH 3/6] Makefile: define curl cflags and libs with object Fam Zheng
2013-09-05 10:20 ` [Qemu-devel] [RFC PATCH 4/6] Makefile: introduce common-obj-m and block-obj-m for DSO Fam Zheng
2013-09-05 19:24   ` Richard Henderson
2013-09-05 19:41     ` Paolo Bonzini
2013-09-05 21:45       ` Peter Maydell
2013-09-06  8:26         ` Paolo Bonzini
2013-09-06  5:53     ` Fam Zheng
2013-09-06  7:20       ` Richard Henderson
2013-09-06  7:27         ` Fam Zheng
2013-09-05 10:20 ` [Qemu-devel] [RFC PATCH 5/6] module: load modules at start Fam Zheng
2013-09-05 11:43   ` Lluís Vilanova
2013-09-06  6:33     ` Fam Zheng
2013-09-05 11:49   ` Michael Tokarev [this message]
2013-09-05 10:20 ` [Qemu-devel] [RFC PATCH 6/6] curl: build as shared library Fam Zheng
2013-09-05 10:25 ` [Qemu-devel] [RFC PATCH 0/6] Shared Library Module Support Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52286FC4.70505@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=famz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.