From: Hannes Reinecke <hare@suse.de>
To: Dave Jones <davej@redhat.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: fix swapped arguments in aic7xxx:ahc_find_pci_device
Date: Thu, 05 Sep 2013 15:39:05 +0200 [thread overview]
Message-ID: <52288979.5050205@suse.de> (raw)
In-Reply-To: <20130905023309.GA10315@redhat.com>
On 09/05/2013 04:33 AM, Dave Jones wrote:
> The prototype for ahc_9005_subdevinfo_valid shows that the caller has the
> arguments in the wrong order.
>
> 637 ahc_9005_subdevinfo_valid(uint16_t device, uint16_t vendor,
> 638 uint16_t subdevice, uint16_t subvendor)
>
> Signed-off-by: Dave Jones <davej@fedoraproject.org>
Acked-by: Hannes Reinecke <hare@suse.de>
>
> diff --git a/drivers/scsi/aic7xxx/aic7xxx_pci.c b/drivers/scsi/aic7xxx/aic7xxx_pci.c
> index 6917b4f..22d5a94 100644
> --- a/drivers/scsi/aic7xxx/aic7xxx_pci.c
> +++ b/drivers/scsi/aic7xxx/aic7xxx_pci.c
> @@ -692,7 +692,7 @@ ahc_find_pci_device(ahc_dev_softc_t pci)
> * ID as valid.
> */
> if (ahc_get_pci_function(pci) > 0
> - && ahc_9005_subdevinfo_valid(vendor, device, subvendor, subdevice)
> + && ahc_9005_subdevinfo_valid(device, vendor, subdevice, subvendor)
> && SUBID_9005_MFUNCENB(subdevice) == 0)
> return (NULL);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-09-05 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 2:33 fix swapped arguments in aic7xxx:ahc_find_pci_device Dave Jones
2013-09-05 13:39 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52288979.5050205@suse.de \
--to=hare@suse.de \
--cc=davej@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.