From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2 0/2] target-arm: Avoid clang sanitizer warnings
Date: Thu, 05 Sep 2013 08:28:12 -0700 [thread overview]
Message-ID: <5228A30C.9050907@twiddle.net> (raw)
In-Reply-To: <1378391908-22137-1-git-send-email-peter.maydell@linaro.org>
On 09/05/2013 07:38 AM, Peter Maydell wrote:
> These patches avoid some clang sanitizer warnings triggered
> on target-arm code which inadvertently shifts into the sign
> bit of a signed integer (which is undefined behaviour in C).
>
> Changes v1->v2:
> * made all the CPSR_* defines unsigned for consistency
> (suggested by rth in review)
>
> Peter Maydell (2):
> target-arm: Use sextract32() in branch decode
> target-arm: Avoid "1 << 31" undefined behaviour
>
> target-arm/cpu.h | 32 ++++++++++++++++----------------
> target-arm/helper.c | 4 ++--
> target-arm/translate.c | 5 +++--
> 3 files changed, 21 insertions(+), 20 deletions(-)
>
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
prev parent reply other threads:[~2013-09-05 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 14:38 [Qemu-devel] [PATCH v2 0/2] target-arm: Avoid clang sanitizer warnings Peter Maydell
2013-09-05 14:38 ` [Qemu-devel] [PATCH v2 1/2] target-arm: Use sextract32() in branch decode Peter Maydell
2013-09-05 14:38 ` [Qemu-devel] [PATCH v2 2/2] target-arm: Avoid "1 << 31" undefined behaviour Peter Maydell
2013-09-05 15:28 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5228A30C.9050907@twiddle.net \
--to=rth@twiddle.net \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.