Re: [PATCH 2/2, 2nd attempt] samples/auto.smb: add logic to obtain credentials

[Martin Wilck <martin.wilck@ts.fujitsu.com>]

On 09/06/2013 11:26 AM, Ian Kent wrote:
> On Fri, 2013-09-06 at 10:23 +0200, Martin Wilck wrote:
>> On 09/06/2013 09:59 AM, Ian Kent wrote:
>>
>>>> -$SMBCLIENT -gNL $key 2>/dev/null| awk -v key="$key" -v opts="$opts" -F'|' -- '
>>>> +creds=/etc/creds/$key
>>>> +if [ -f "$creds" ]; then
>>>> +    opts="$opts"',uid=$UID,gid=$GID,credentials='"$creds"
>>>> +    smbopts="-A $creds"
>>>> +else
>>>> +    get_krb5_cache
>>>> +    if [ -n "$cache" ]; then
>>>> +        opts="$opts"',multiuser,cruid=$UID,sec=krb5i'
>>>> +        smbopts="-k"
>>>> +        export KRB5CCNAME=$cache 
>>>> +    else
>>>> +        opts="$opts"',guest'
>>>
>>> Why add guest?
>>
>> "guest" means "don't prompt for a password" which is what mount.cifs
>> will attempt to do if no credentials are available already (e.g. via
>> kerberos ticket). IMO that's what's needed for autofs, otherwise the
>> mount attempt might hang waiting for password input.
>>
>>> Is that going to change the behavior of the existing script.
>>
>> "guest" mode was all the previous script could do, thus it seems to have
>> been written with servers in mind that only offered guest access in the
>> first place (und thus wouldn't prompt for a password, either).
> 
> From my POV auto.smb is an example program map that happens to get
> installed. I don't think it was never meant to be sophisticated.

Sure. We might as well keep it as it is, or just provide the new one
alongside the old one as another example.

> You are saying that adding guest doesn't change anything as it is the
> default when no credentials are provided, correct?

That's right.

Martin

-- 
Dr. Martin Wilck
PRIMERGY System Software Engineer
x86 Server Engineering

FUJITSU
Fujitsu Technology Solutions GmbH
Heinz-Nixdorf-Ring 1
33106 Paderborn, Germany
Phone:			++49 5251 525 2796
Fax:			++49 5251 525 2820
Email:			martin.wilck@ts.fujitsu.com
Internet:		http://ts.fujitsu.com
Company Details:	http://ts.fujitsu.com/imprint