From: David Vrabel <david.vrabel@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: <linux-kernel@vger.kernel.org>, <xen-devel@lists.xenproject.org>,
<boris.ostrovsky@oracle.com>
Subject: Re: [PATCH] xen/p2m: Export set_phys_to_machine.
Date: Fri, 6 Sep 2013 17:07:40 +0100 [thread overview]
Message-ID: <5229FDCC.5000705@citrix.com> (raw)
In-Reply-To: <1378476042-4821-1-git-send-email-konrad.wilk@oracle.com>
On 06/09/13 15:00, Konrad Rzeszutek Wilk wrote:
> We have already exported 'get_phys_to_machine' and there are
> third-party drivers that depend on this other symbol. As such
> lets make this balanced and also export this symbol.
I'm not sure this is a good idea. It isn't clear why any out of tree
driver would need to mess with the p2m (or that we would actually trust
a third party driver to do this correctly...).
Also, the general kernel policy is not to export symbols that aren't
used by something in the kernel tree itself.
David
next prev parent reply other threads:[~2013-09-06 16:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 14:00 [PATCH] xen/p2m: Export set_phys_to_machine Konrad Rzeszutek Wilk
2013-09-06 14:06 ` [Xen-devel] " Jan Beulich
2013-09-06 14:39 ` Konrad Rzeszutek Wilk
2013-09-06 14:39 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-09-06 14:49 ` Jan Beulich
2013-09-06 14:49 ` [Xen-devel] " Jan Beulich
2013-09-06 14:06 ` Jan Beulich
2013-09-06 16:07 ` David Vrabel
2013-09-06 16:07 ` David Vrabel [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-09-06 14:00 Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5229FDCC.5000705@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.