Re: [meta-fsl-arm-extra][PATCH 3/8] Add a machine configuration for cfa-10037

[Alexandre Belloni <alexandre.belloni@free-electrons.com>]

On 06/09/2013 18:40, Otavio Salvador wrote:
> On Fri, Sep 6, 2013 at 1:34 PM, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
>> On 06/09/2013 14:10, Otavio Salvador wrote:
>>> On Fri, Sep 6, 2013 at 8:59 AM, Daiane Angolini
>>> <daiane.angolini@freescale.com> wrote:
>>>> On 09/05/2013 06:21 PM, Alexandre Belloni wrote:
>>>>> The cfa-10037 is a breakout board for the cfa-10036.
>>>>>
>>>>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>>>>> ---
>>>>>   conf/machine/cfa10037.conf | 9 +++++++++
>>>>>   1 file changed, 9 insertions(+)
>>>>>   create mode 100644 conf/machine/cfa10037.conf
>>>>>
>>>>> diff --git a/conf/machine/cfa10037.conf b/conf/machine/cfa10037.conf
>>>>> new file mode 100644
>>>>> index 0000000..7dbdd55
>>>>> --- /dev/null
>>>>> +++ b/conf/machine/cfa10037.conf
>>>>> @@ -0,0 +1,9 @@
>>>>> +#@TYPE: Machine
>>>>> +#@NAME: Crystalfontz CFA-10037
>>>>> +#@SOC: i.MX28
>>>>> +#@DESCRIPTION: Machine configuration for CFA-10037
>>>>> +
>>>>> +include conf/machine/include/cfa10036.inc
>>>>> +
>>>>> +KERNEL_DEVICETREE += "imx28-cfa10037.dtb"
>>>> oh, you need both devicetree files....
>>> Really? I think it is not loading both. Alexandre, can you comment on this?
>>>
>> Sure, you are right, it is only loading one. But in the case the eeprom
>> is not yet written, you may end up with barebox trying to use the
>> cfa-10036 DT. Hence, I'm letting that DT so that you can still boot. You
>> may also detach the cfa-10036 from the peripheral board and so end up
>> booting only on the cfa-10036.
>>
>> I did the same for cfa-10055 and cfa-10056 which are actually cfa-10037
>> with an attached touchscreen. If you ever want to remove it, you
>> probably want to still be able to boot it.
>>
>> Actually, I was wondering whether it wouldn't be better to simply always
>> include all the DTs.
> Personally I disagree with this approach. We are not working with PC
> so people are expected to know what they're doing and choose the right
> board.
>
> I will let you to decide on this as I am clueless about the boards and
> you're the maintainer of these. So in the end it is your call.
>

I personnally don't mind removing the cfa-10037 from the cfa-10055 and
cfa-10056 but I would prefer keeping the cfa-10036 DT for all the board,
as explained, you may end up with a board with an empty eeprom and still
want to boot (for example, to flash that eeprom ;) ).

Also, I believe those boards may end up being used by unexperienced
people (think raspberry pi ;) ) or by people wanting to use the same SD
card on multiple different boards or event moving the cfa-10036+sdcard
to another peripheral board.

Just to be clear enough, the cfa-10036 is a SoM including the imx28,
RAM, sdcard and usb with a 200 pin SO-DIMM connector. You can then host
that SoM on different peripheral boards. See:
http://www.crystalfontz.com/products/index-linux-SOM.html

I can send a v2 with the extre cfa-10037 dt removed.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com