From: Mark Tinguely <tinguely@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfs: aborted buf items can be in the AIL.
Date: Fri, 06 Sep 2013 14:39:24 -0500 [thread overview]
Message-ID: <522A2F6C.2030103@sgi.com> (raw)
In-Reply-To: <1378208858-20557-2-git-send-email-david@fromorbit.com>
On 09/03/13 06:47, Dave Chinner wrote:
> From: Dave Chinner<dchinner@redhat.com>
>
> Saw this on generic/270 after a DQALLOC transaction overrun
> shutdown:
>
> XFS: Assertion failed: !(bip->bli_item.li_flags& XFS_LI_IN_AIL), file: fs/xfs/xfs_buf_item.c, line: 952
> .....
> xfs_buf_item_relse+0x4f/0xd0
> xfs_buf_item_unlock+0x1b4/0x1e0
> xfs_trans_free_items+0x7d/0xb0
> xfs_trans_cancel+0x13c/0x1b0
> xfs_symlink+0x37e/0xa60
> ....
>
> When a transaction abort occured.
>
> If we are aborting a transaction and trigger this code path, then
> the item may be dirty. If the item is dirty, then it may be in the
> AIL. Hence if we are aborting, we need to check if the item is in
> the AIL and remove it before freeing it.
>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
> ---
This is fine for Linux 3.12. Christoph's reference counting reorg sounds
interesting.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-06 19:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 11:47 [PATCH 0/2] xfs: more shutdown-related fixes Dave Chinner
2013-09-03 11:47 ` [PATCH 1/2] xfs: aborted buf items can be in the AIL Dave Chinner
2013-09-06 19:39 ` Mark Tinguely [this message]
2013-09-03 11:47 ` [PATCH 2/2] xfs: don't assert fail on bad inode numbers Dave Chinner
2013-09-06 19:54 ` Mark Tinguely
2013-10-18 16:51 ` Rich Johnston
2013-09-03 19:02 ` [PATCH 0/2] xfs: more shutdown-related fixes Christoph Hellwig
2013-09-03 19:56 ` Dave Chinner
2013-09-10 22:39 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522A2F6C.2030103@sgi.com \
--to=tinguely@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.