Re: [PATCH -net 0/2] bonding: fix arp_validate desync state & race

[Nikolay Aleksandrov <nikolay@redhat.com>]

On 09/06/2013 09:41 PM, Nikolay Aleksandrov wrote:
> Hello all,
> These two patches aim to fix the possible de-sync state which the bond
> can enter if we have arp_validate without arp_interval or the other way
> around. They also fix a race condition between arp_validate setting and
> mode changing.
> 
> Patch 01 - fixes the race condition between store_arp_validate and bond
> mode change by using rtnl for sync
> Patch 02 - fixes the possible de-sync state by setting/unsetting recv_probe
> if arp_interval is set/unset and also if arp_validate is set/unset
> 
> Best regards,
>  Nikolay Aleksandrov
> 
> 
> Nikolay Aleksandrov (2):
>   bonding: fix store_arp_validate race with mode change
>   bonding: fix bond_arp_rcv setting and arp validate desync state
> 
>  drivers/net/bonding/bond_main.c  |  4 ++--
>  drivers/net/bonding/bond_sysfs.c | 31 +++++++++++++++++++++++++------
>  drivers/net/bonding/bonding.h    |  1 +
>  3 files changed, 28 insertions(+), 8 deletions(-)
> 
Ugh, self-nack I just noticed the mode check in store_arp_validate passes
if new_value is 0.

I'll wait some time to see if there isn't anything else and re-post.

Cheers,
 Nik