From: Mark Tinguely <tinguely@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: factor all the kmalloc-or-vmalloc fallback allocations
Date: Fri, 06 Sep 2013 15:37:42 -0500 [thread overview]
Message-ID: <522A3D16.3010709@sgi.com> (raw)
In-Reply-To: <1378119180-31380-3-git-send-email-david@fromorbit.com>
On 09/02/13 05:53, Dave Chinner wrote:
> From: Dave Chinner<dchinner@redhat.com>
>
> We have quite a few places now where we do:
>
> x = kmem_zalloc(large size)
> if (!x)
> x = kmem_zalloc_large(large size)
>
> and do a similar dance when freeing the memory. kmem_free() already
> does the correct freeing dance, and kmem_zalloc_large() is only ever
> called in these constructs, so just factor it all into
> kmem_zalloc_large() and kmem_free().
>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
> ---
Good start on the allocation changes.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-06 20:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 10:52 [PATCH 0/2] xfs: fix some new memory allocation failures Dave Chinner
2013-09-02 10:52 ` [PATCH 1/2] xfs: fix memory allocation failures with ACLs Dave Chinner
2013-09-06 19:59 ` Mark Tinguely
2013-09-02 10:53 ` [PATCH 2/2] xfs: factor all the kmalloc-or-vmalloc fallback allocations Dave Chinner
2013-09-06 20:37 ` Mark Tinguely [this message]
2013-09-02 17:03 ` [PATCH 0/2] xfs: fix some new memory allocation failures Mark Tinguely
2013-09-02 22:20 ` Dave Chinner
2013-09-03 13:07 ` Mark Tinguely
2013-09-03 20:04 ` Dave Chinner
2013-09-03 20:46 ` Mark Tinguely
2013-09-03 21:16 ` Dave Chinner
2013-09-03 22:38 ` Mark Tinguely
2013-09-10 22:40 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522A3D16.3010709@sgi.com \
--to=tinguely@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.