From: Jonathan Cameron <jic23@kernel.org>
To: Derek Basehore <dbasehore@chromium.org>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bill Pemberton <wfp5p@virginia.edu>,
Bryan Freed <bfreed@chromium.org>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: isl29018: Fix uninitialized value
Date: Sun, 08 Sep 2013 14:48:52 +0100 [thread overview]
Message-ID: <522C8044.6090502@kernel.org> (raw)
In-Reply-To: <1377807250-30150-1-git-send-email-dbasehore@chromium.org>
On 08/29/13 21:14, Derek Basehore wrote:
> The lux_uscale value is not initialized at probe. The value will be
> uninitialized unless a value is written to it through the iio channel interface.
> This fixes that.
>
> Signed-off-by: Derek Basehore <dbasehore@chromium.org>
> Reviewed-on: https://gerrit.chromium.org/gerrit/65998
Thanks,
Applied to the fixes-togreg branch of iio.git
I'll send this onwards in a few days.
Jonathan
> ---
> drivers/staging/iio/light/isl29018.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
> index 82478a5..28c6386 100644
> --- a/drivers/staging/iio/light/isl29018.c
> +++ b/drivers/staging/iio/light/isl29018.c
> @@ -564,6 +564,7 @@ static int isl29018_probe(struct i2c_client *client,
> mutex_init(&chip->lock);
>
> chip->lux_scale = 1;
> + chip->lux_uscale = 0;
> chip->range = 1000;
> chip->adc_bit = 16;
> chip->suspended = false;
>
prev parent reply other threads:[~2013-09-08 12:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 20:14 [PATCH] iio: isl29018: Fix uninitialized value Derek Basehore
2013-09-08 13:48 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522C8044.6090502@kernel.org \
--to=jic23@kernel.org \
--cc=bfreed@chromium.org \
--cc=dbasehore@chromium.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.